Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: chrome/common/ntp_logging_events.h

Issue 102433009: Most visited iframe now postMessage to signal the iframing page that the link has been displayed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed support for multiple thumbnail URLs, refactored UMA logging. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_NTP_LOGGING_EVENTS_H_ 5 #ifndef CHROME_COMMON_NTP_LOGGING_EVENTS_H_
6 #define CHROME_COMMON_NTP_LOGGING_EVENTS_H_ 6 #define CHROME_COMMON_NTP_LOGGING_EVENTS_H_
7 7
8 // The different types of events that are logged from the NTP. 8 // The different types of events that are logged from the NTP.
9 enum NTPLoggingEventType { 9 enum NTPLoggingEventType {
10 // The user moused over an NTP tile or title. 10 // The user moused over an NTP tile or title.
11 NTP_MOUSEOVER = 0, 11 NTP_MOUSEOVER = 0,
12 12
13 // The page attempted to load a thumbnail image. 13 // The page attempted to load a thumbnail image.
14 NTP_THUMBNAIL_ATTEMPT = 1, 14 NTP_THUMBNAIL_ATTEMPT = 1,
15 15
16 // There was an error in loading both the thumbnail image and the fallback 16 // There was an error in loading both the thumbnail image and the fallback
17 // (if it was provided), resulting in a grey tile. 17 // (if it was provided), resulting in a grey tile.
18 NTP_THUMBNAIL_ERROR = 2, 18 NTP_THUMBNAIL_ERROR = 2,
19 19
20 // The page attempted to load a thumbnail URL while a fallback thumbnail was 20 // DEPRECATED: NTP_FALLBACK_THUMBNAIL_REQUESTED = 3,
sky 2014/01/09 00:25:34 nit: Since you're commenting out the constants the
beaudoin 2014/01/15 23:39:56 Just cleaned up this whole enum. Since it's only i
21 // provided. 21 // DEPRECATED: NTP_FALLBACK_THUMBNAIL_USED = 4,
22 NTP_FALLBACK_THUMBNAIL_REQUESTED = 3,
23
24 // The primary thumbnail image failed to load and caused us to use the
25 // secondary thumbnail as a fallback.
26 NTP_FALLBACK_THUMBNAIL_USED = 4,
27 22
28 // The suggestion is coming from the server. 23 // The suggestion is coming from the server.
29 NTP_SERVER_SIDE_SUGGESTION = 5, 24 NTP_SERVER_SIDE_SUGGESTION = 5,
30 25
31 // The suggestion is coming from the client. 26 // The suggestion is coming from the client.
32 NTP_CLIENT_SIDE_SUGGESTION = 6, 27 NTP_CLIENT_SIDE_SUGGESTION = 6,
33 28
34 // The visuals of that tile are handled externally by the page itself. 29 // The visuals of that tile are handled externally by the page itself.
35 NTP_EXTERNAL_TILE = 7, 30 NTP_EXTERNAL_TILE = 7,
36 31
32 // Indicates a tile was rendered, no matter if it's a thumbnail, a gray tile
33 // or an external tile.
34 NTP_TILE = 8,
35
36 // Used when no thumbnail is specified and a gray tile with the domain is used
37 // as the main tile.
38 NTP_GRAY_TILE = 9,
39
40 // Used a gray tile with the domain as the fallback for a failed thumbnail.
41 NTP_GRAY_TILE_FALLBACK = 10,
42
43 // The visuals of that tile's fallback are handled externally.
44 NTP_EXTERNAL_FALLBACK = 11,
45
37 NTP_NUM_EVENT_TYPES 46 NTP_NUM_EVENT_TYPES
38 }; 47 };
39 48
40 #endif // CHROME_COMMON_NTP_LOGGING_EVENTS_H_ 49 #endif // CHROME_COMMON_NTP_LOGGING_EVENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698