Fix bug where wrong search engine is shown in Settings.

Fix bug where wrong search engine is shown in Settings.

We were using getDefaultSearchEngineIndex() as an index into the list of
TemplateUrls returned by getLocalizedSearchEngines(), which is
incorrect, but happens to work most of the time.

BUG=469238
Committed: https://crrev.com/82e8dcf1dec6da3b4da1327ef97ddfd4a87fd529
Cr-Commit-Position: refs/heads/master@{#321833}

[newt (away), 2015-03-21 00:37:35]

newt@chromium.org changed reviewers:
+ tedchoc@chromium.org

[newt (away), 2015-03-21 00:37:36]

PTAL

[newt (away), 2015-03-21 00:39:14]

finnur: Can you check your rewrite of this code and fix it too, if it also
suffers form this bug?

[Ted C, 2015-03-23 15:12:10]

https://codereview.chromium.org/1024213003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
(right):

https://codereview.chromium.org/1024213003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java:82:
if (valueIndex != -1) setValueIndex(valueIndex);
in what cases do we expect this to be -1?

[newt (away), 2015-03-23 16:43:16]

https://codereview.chromium.org/1024213003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
(right):

https://codereview.chromium.org/1024213003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java:82:
if (valueIndex != -1) setValueIndex(valueIndex);
On 2015/03/23 15:12:10, Ted C wrote:
> in what cases do we expect this to be -1?

If the search engine is managed and set to internalsearch.example.com, this
could be -1. We probably want to handle that case better, though, and actually
show the search engine's name in the summary.

[Ted C, 2015-03-23 17:21:06]

lgtm

[newt (away), 2015-03-23 18:44:12]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-03-23 18:44:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024213003/1

[commit-bot: I haz the power, 2015-03-23 19:45:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-23 19:46:25]

Patchset 1 (id:??) landed as
https://crrev.com/82e8dcf1dec6da3b4da1327ef97ddfd4a87fd529
Cr-Commit-Position: refs/heads/master@{#321833}