chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java - Issue 1024213003: Fix bug where wrong search engine is shown in Settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

Issue 1024213003: Fix bug where wrong search engine is shown in Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

index efe0fe7959626e2075ef57d9cbbe95a69e7d13dd..f1cdfdac51b5f40f7eb7bc3a34d88fa51ded48a3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

@@ -124,7 +124,11 @@ public class TemplateUrlService {

}

/**

- * Get the collection of localized search engines.

+ * Returns a list of the prepopulated search engines.

+ *

+ * Warning: TemplateUrl.getIndex() is *not* an index into this list, since this list contains

+ * only prepopulated search engines. E.g. getLocalizedSearchEngines().get(0).getIndex() could

+ * return 3.

public List<TemplateUrl> getLocalizedSearchEngines() {

ThreadUtils.assertOnUiThread();