Pass through context information in error messages

Pass through context information in error messages

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/4279f2df5c33f583ca0355a285faa8f7daba3b43

[Siggi Cherem (dart-lang), 2015-03-23 21:53:39]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-03-23 21:57:40]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2015-03-23 22:01:43]

sigmund@google.com changed reviewers:
+ vsm@google.com

[Siggi Cherem (dart-lang), 2015-03-23 22:01:44]

This uses a change that I plan to submit to source_span to make it easy to
include the `contextLine` in error messages. 

(That change to source_span is at https://codereview.chromium.org/1028813002/)

https://codereview.chromium.org/1023893004/diff/40001/lib/src/summary.dart
File lib/src/summary.dart (right):

https://codereview.chromium.org/1023893004/diff/40001/lib/src/summary.dart#ne...
lib/src/summary.dart:159: ? (span as SourceSpanContext).contextLine
it's frustrating that here we are required to put a cast to avoid the static
warning from the spec. Even though `span` is a final field and could be treated
like a local variable in terms of mutation here.

[vsm, 2015-03-23 22:11:34]

lgtm

https://codereview.chromium.org/1023893004/diff/40001/lib/src/summary.dart
File lib/src/summary.dart (right):

https://codereview.chromium.org/1023893004/diff/40001/lib/src/summary.dart#ne...
lib/src/summary.dart:159: ? (span as SourceSpanContext).contextLine
On 2015/03/23 22:01:44, Siggi Cherem (dart-lang) wrote:
> it's frustrating that here we are required to put a cast to avoid the static
> warning from the spec. Even though `span` is a final field and could be
treated
> like a local variable in terms of mutation here.

You could file a type promo bug on this.

[Siggi Cherem (dart-lang), 2015-03-26 22:18:53]

Patchset #2 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2015-03-26 22:20:18]

FYI - we made small changes to source_span during the review process, so I've
adjusted the code here accordingly before submtiting. I also included a test to
make sure we are printing the right thing.

https://codereview.chromium.org/1023893004/diff/40001/lib/src/summary.dart
File lib/src/summary.dart (right):

https://codereview.chromium.org/1023893004/diff/40001/lib/src/summary.dart#ne...
lib/src/summary.dart:159: ? (span as SourceSpanContext).contextLine
On 2015/03/23 22:11:34, vsm wrote:
> On 2015/03/23 22:01:44, Siggi Cherem (dart-lang) wrote:
> > it's frustrating that here we are required to put a cast to avoid the static
> > warning from the spec. Even though `span` is a final field and could be
> treated
> > like a local variable in terms of mutation here.
> 
> You could file a type promo bug on this.  

We chatted offline: turns out this is a legitimate case. A subclass could
override a final field with a getter, which in turn could return a different
value every time. Oh well.

[Siggi Cherem (dart-lang), 2015-03-26 22:25:29]

Committed patchset #2 (id:80001) manually as
4279f2df5c33f583ca0355a285faa8f7daba3b43 (presubmit successful).