Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: test/report_test.dart

Issue 1023893004: Pass through context information in error messages (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/expect/server_mode/html_input.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/report_test.dart
diff --git a/test/report_test.dart b/test/report_test.dart
index c1e282b68f2ac06d6fd3f7b7443251726f7c7d2c..49d4105dd1a3c5e27294bfd2b6febbc4e1b23858 100644
--- a/test/report_test.dart
+++ b/test/report_test.dart
@@ -24,25 +24,41 @@ void main() {
test1() {
x = /*severe:StaticTypeError*/"hi";
}
- ''',
+ '''.replaceAll('\n ', '\n'),
'package:foo/bar.dart': '''
num x;
test2() {
int y = /*info:DownCast*/x;
}
- ''',
+ '''.replaceAll('\n ', '\n'),
};
testChecker(files);
var reporter = new SummaryReporter();
testChecker(files, reporter: reporter);
- var summary1 = reporter.result;
- expect(summary1.loose['file:///main.dart'].messages.length, 1);
- var barUrl = 'package:foo/bar.dart';
- expect(summary1.packages['foo'].libraries[barUrl].messages.length, 1);
+ _verifySummary(GlobalSummary summary) {
+ var mainLib = summary.loose['file:///main.dart'];
+ expect(mainLib.messages.length, 1);
- var summary2 = GlobalSummary.parse(summary1.toJsonMap());
- expect(summary2.loose['file:///main.dart'].messages.length, 1);
- expect(summary2.packages['foo'].libraries[barUrl].messages.length, 1);
+ var mainMessage = mainLib.messages[0];
+ expect(mainMessage.kind, "StaticTypeError");
+ expect(mainMessage.level, "severe");
+ expect(mainMessage.span.text, '"hi"');
+ expect(mainMessage.span.context,
+ ' x = /*severe:StaticTypeError*/"hi";\n');
+
+ var barLib = summary.packages['foo'].libraries['package:foo/bar.dart'];
+ expect(barLib.messages.length, 1);
+ var barMessage = barLib.messages[0];
+ expect(barMessage.kind, "DownCast");
+ expect(barMessage.level, "info");
+ expect(barMessage.span.text, 'x');
+ expect(barMessage.span.context,
+ ' int y = /*info:DownCast*/x;\n');
+ }
+
+ var original = reporter.result;
+ _verifySummary(original);
+ _verifySummary(GlobalSummary.parse(original.toJsonMap()));
});
}
« no previous file with comments | « test/codegen/expect/server_mode/html_input.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698