Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 10238006: Increase eval compilation cache hits. (Closed)

Created:
8 years, 8 months ago by ulan
Modified:
5 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Increase eval compilation cache hits. This CL introduces two changes to the eval compilation cache. Firstly, instead of checking for SharedFunctionInfo equivalence to ensure equivalence of direct eval call sites we now check for Script and scope start position equivalence. Furthermore, we increase the cache hits by allowing to share global eval code for direct and indirect call sites, e.g. in the case var x = eval; x("12"); eval("12"); Patch from Steven Keuchel <keuchel@chromium.org>; Original CL: http://codereview.chromium.org/8879010/ BUG=v8:1854 TEST=existing tests in mjsunit R=vegorov@chromium.org

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/compilation-cache.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compilation-cache.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
Could you please take a look? This is one of Steven's open CLs.
8 years, 8 months ago (2012-04-26 13:19:09 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 8 months ago (2012-04-26 13:37:59 UTC) #2
LGTM if we have good test coverage that will verify the cases when caching is
valid and invalid.

also different interesting cases:

var a = 10;
eval("a");
with ({a:11}) { eval("a"); } 

and similiar.

Powered by Google App Engine
This is Rietveld 408576698