src/objects.cc - Issue 10238006: Increase eval compilation cache hits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 10238006: Increase eval compilation cache hits. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 41f2ab6d8823f2e85ee1ec636e0016a495273fa6..6adfaa6d0b91c3cb21bbc499f0ff8c85ed153db1 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -10497,7 +10497,7 @@ class StringSharedKey : public HashTableKey {

if (!other->IsFixedArray()) return false;

FixedArray* other_array = FixedArray::cast(other);

SharedFunctionInfo* shared = SharedFunctionInfo::cast(other_array->get(0));

- if (shared != shared_) return false;

+ if (shared->script() != shared_->script()) return false;

int language_unchecked = Smi::cast(other_array->get(2))->value();

ASSERT(language_unchecked == CLASSIC_MODE ||

language_unchecked == STRICT_MODE ||

« no previous file with comments | « src/compilation-cache.cc ('k') | no next file » | no next file with comments »