Move absolute path conversion back to the FILE thread.

Move absolute path conversion back to the FILE thread.

In commit 3576d4645180fee42ab40475dd182fcd2afdebea the conversion of
the selected directory to an absolute path was moved from
FileSystemChooseEntryFunction::ConfirmDirectoryAccessOnFileThread to
FilesSelected. As the latter runs on the UI thread this violated I/O
restrictions and results in a DCHECK. This was not caught by tests
because in the test environment I/O appears to be allowed on the main
thread.

This change splits the call to IsUnderNonNativeLocalPath from the
conversion to an absolute path.

BUG=457841
Committed: https://crrev.com/16e6852d567be9bb7e5789a27748be9df9794b50
Cr-Commit-Position: refs/heads/master@{#321510}

[Reilly Grant (use Gerrit), 2015-03-19 20:49:38]

reillyg@chromium.org changed reviewers:
+ benwells@chromium.org

[Reilly Grant (use Gerrit), 2015-03-19 20:49:38]

Ben, please take a look. I'd like to fix test as well so that it would have
caught this but I'm not sure where ThreadRestrictions::SetIOAllowed is being
called.

[benwells, 2015-03-20 00:49:38]

benwells@chromium.org changed reviewers:
+ mtomasz@chromium.org

[benwells, 2015-03-20 00:49:39]

Sending to mtomasz who just change this.

[mtomasz, 2015-03-20 01:00:27]

lgtm

https://codereview.chromium.org/1023793002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

https://codereview.chromium.org/1023793002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:672: base::FilePath
check_path =
nit: This can be const.

[Reilly Grant (use Gerrit), 2015-03-20 01:55:21]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-03-20 01:55:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/1023793002/#ps20001
(title: "Make check_path const.")

[commit-bot: I haz the power, 2015-03-20 01:55:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1023793002/20001

[commit-bot: I haz the power, 2015-03-20 03:41:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-20 03:41:51]

Patchset 2 (id:??) landed as
https://crrev.com/16e6852d567be9bb7e5789a27748be9df9794b50
Cr-Commit-Position: refs/heads/master@{#321510}