Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1023793002: Move absolute path conversion back to the FILE thread. (Closed)

Created:
5 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 9 months ago
Reviewers:
mtomasz, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, nhiroki, tzik, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move absolute path conversion back to the FILE thread. In commit 3576d4645180fee42ab40475dd182fcd2afdebea the conversion of the selected directory to an absolute path was moved from FileSystemChooseEntryFunction::ConfirmDirectoryAccessOnFileThread to FilesSelected. As the latter runs on the UI thread this violated I/O restrictions and results in a DCHECK. This was not caught by tests because in the test environment I/O appears to be allowed on the main thread. This change splits the call to IsUnderNonNativeLocalPath from the conversion to an absolute path. BUG=457841 Committed: https://crrev.com/16e6852d567be9bb7e5789a27748be9df9794b50 Cr-Commit-Position: refs/heads/master@{#321510}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make check_path const. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M chrome/browser/extensions/api/file_system/file_system_api.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Reilly Grant (use Gerrit)
Ben, please take a look. I'd like to fix test as well so that it ...
5 years, 9 months ago (2015-03-19 20:49:38 UTC) #2
benwells
Sending to mtomasz who just change this.
5 years, 9 months ago (2015-03-20 00:49:39 UTC) #4
mtomasz
lgtm https://codereview.chromium.org/1023793002/diff/1/chrome/browser/extensions/api/file_system/file_system_api.cc File chrome/browser/extensions/api/file_system/file_system_api.cc (right): https://codereview.chromium.org/1023793002/diff/1/chrome/browser/extensions/api/file_system/file_system_api.cc#newcode672 chrome/browser/extensions/api/file_system/file_system_api.cc:672: base::FilePath check_path = nit: This can be const.
5 years, 9 months ago (2015-03-20 01:00:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023793002/20001
5 years, 9 months ago (2015-03-20 01:55:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 03:41:20 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 03:41:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16e6852d567be9bb7e5789a27748be9df9794b50
Cr-Commit-Position: refs/heads/master@{#321510}

Powered by Google App Engine
This is Rietveld 408576698