Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5204)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.h

Issue 1023793002: Move absolute path conversion back to the FILE thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make check_path const. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/file_system/file_system_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/file_system/file_system_api.h
diff --git a/chrome/browser/extensions/api/file_system/file_system_api.h b/chrome/browser/extensions/api/file_system/file_system_api.h
index a2f9e4dbd89d98031aacd2016830aadd73eb5d70..187f381e4a9ad90ebeb2624ae234794053d80ff9 100644
--- a/chrome/browser/extensions/api/file_system/file_system_api.h
+++ b/chrome/browser/extensions/api/file_system/file_system_api.h
@@ -159,13 +159,13 @@ class FileSystemChooseEntryFunction : public FileSystemEntryFunction {
void FilesSelected(const std::vector<base::FilePath>& path);
void FileSelectionCanceled();
- // Check if |check_path|, the canonicalized form of the chosen directory
- // |paths|, is or is an ancestor of a sensitive directory. If so, show a
- // dialog to confirm that the user wants to open the directory.
- // Calls OnDirectoryAccessConfirmed if the directory isn't sensitive or the
- // user chooses to open it. Otherwise, calls FileSelectionCanceled.
+ // Check if the chosen directory is or is an ancestor of a sensitive
+ // directory. If so, show a dialog to confirm that the user wants to open the
+ // directory. Calls OnDirectoryAccessConfirmed if the directory isn't
+ // sensitive or the user chooses to open it. Otherwise, calls
+ // FileSelectionCanceled.
void ConfirmDirectoryAccessOnFileThread(
- const base::FilePath& check_path,
+ bool non_native_path,
const std::vector<base::FilePath>& paths,
content::WebContents* web_contents);
void OnDirectoryAccessConfirmed(const std::vector<base::FilePath>& paths);
« no previous file with comments | « no previous file | chrome/browser/extensions/api/file_system/file_system_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698