Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1023743002: Merge Disable Keyboard in Maximize Mode (Closed)

Created:
5 years, 9 months ago by jonross
Modified:
5 years, 9 months ago
Reviewers:
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, sadrul, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Merge Disable Keyboard in Maximize Mode Disable Keyboard in Maximize Mode Update logic for disabling keyboards on X11 when Maximize Mode is activated. TBR=sadrul@chromium.org, skuhne@chromium.org NOTRY=true TEST=Manual testing on device BUG=chrome-os-partner:37106 Review URL: https://codereview.chromium.org/991933002 Cr-Commit-Position: refs/heads/master@{#319672} (cherry picked from commit d50b6df7a1454fb3a3fa485f0c2690be902e32a3)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023743002/1
5 years, 9 months ago (2015-03-19 14:48:32 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 9 months ago (2015-03-19 14:48:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023743002/1
5 years, 9 months ago (2015-03-19 14:49:29 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 14:50:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698