Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 991933002: Disable Keyboard in Maximize Mode (Closed)

Created:
5 years, 9 months ago by jonross
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, sadrul, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Keyboard in Maximize Mode Update logic for disabling keyboards on X11 when Maximize Mode is activated. TEST=Manual testing on device BUG=chrome-os-partner:37106 Committed: https://crrev.com/d50b6df7a1454fb3a3fa485f0c2690be902e32a3 Cr-Commit-Position: refs/heads/master@{#319672}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 12 (3 generated)
jonross
Hi, Could you provide an owners review for ui/events/platform/x11 Thanks
5 years, 9 months ago (2015-03-09 16:45:55 UTC) #2
jonross
Hi, Could you provide an owners review for ui/events/platform/x11 Thanks
5 years, 9 months ago (2015-03-09 16:45:57 UTC) #3
jonross
skuhne@chromium.org: Please review changes in ash/wm/maximize_mode/ Thanks
5 years, 9 months ago (2015-03-09 16:46:30 UTC) #5
sadrul
lgtm
5 years, 9 months ago (2015-03-09 16:48:28 UTC) #6
Mr4D (OOO till 08-26)
lgtm https://codereview.chromium.org/991933002/diff/1/ui/events/platform/x11/x11_hotplug_event_handler.cc File ui/events/platform/x11/x11_hotplug_event_handler.cc (right): https://codereview.chromium.org/991933002/diff/1/ui/events/platform/x11/x11_hotplug_event_handler.cc#newcode46 ui/events/platform/x11/x11_hotplug_event_handler.cc:46: "ROCKCHIP-I2S Headset Jack"}; Not quite sure what the ...
5 years, 9 months ago (2015-03-09 16:56:21 UTC) #7
jonross
https://codereview.chromium.org/991933002/diff/1/ui/events/platform/x11/x11_hotplug_event_handler.cc File ui/events/platform/x11/x11_hotplug_event_handler.cc (right): https://codereview.chromium.org/991933002/diff/1/ui/events/platform/x11/x11_hotplug_event_handler.cc#newcode46 ui/events/platform/x11/x11_hotplug_event_handler.cc:46: "ROCKCHIP-I2S Headset Jack"}; On 2015/03/09 16:56:21, Mr4D wrote: > ...
5 years, 9 months ago (2015-03-09 16:59:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991933002/1
5 years, 9 months ago (2015-03-09 17:00:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 17:38:16 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:38:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d50b6df7a1454fb3a3fa485f0c2690be902e32a3
Cr-Commit-Position: refs/heads/master@{#319672}

Powered by Google App Engine
This is Rietveld 408576698