Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102373006: Merge 240486 "Implement the spring charger replacement UI and ad..." (Closed)

Created:
7 years ago by jennyz
Modified:
7 years ago
Reviewers:
jennyz
CC:
chromium-reviews, sadrul, jar (doing other things), derat+watch_chromium.org, ben+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Merge 240486 "Implement the spring charger replacement UI and ad..." > Implement the spring charger replacement UI and add related UMA stats. > > This cl depends on > https://codereview.chromium.org/105923003/ > to be land before it. > > BUG=320708, 321419 > R=derat@chromium.org, xiyuan@chromium.org > TBR=isherman, pam, sky > > Review URL: https://codereview.chromium.org/107103004 TBR=jennyz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+602 lines, --6 lines) Patch
M ash/system/chromeos/power/power_status.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/chromeos/power/power_status.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M ash/system/chromeos/power/tray_power.h View 3 chunks +17 lines, -0 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 5 chunks +37 lines, -1 line 0 comments Download
M ash/system/tray/default_system_tray_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +126 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/chromeos/charger_replace/charger_link_dialog.h View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/charger_replace/charger_link_dialog.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/charger_replace/charger_replacement_dialog.h View 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc View 1 chunk +137 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/charger_replacement.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/chromeos/charger_replacement.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/chromeos/charger_replacement.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A + chrome/browser/ui/webui/chromeos/charger_replacement_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/chromeos/charger_replacement_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/chromeos/charger_replacement_ui.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/chromeos/charger_replacement_ui.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/metrics/actions/chromeactions.txt View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jennyz
7 years ago (2013-12-13 01:30:39 UTC) #1
jennyz
7 years ago (2013-12-13 01:34:23 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r240508.

Powered by Google App Engine
This is Rietveld 408576698