Issue 1023673007: Subzero: Fix inappropriate use of nullptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1023673007: Subzero: Fix inappropriate use of nullptr. (Closed)

Created:
5 years, 9 months ago by Jim Stichnoth

Modified:
5 years, 9 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Fix inappropriate use of nullptr. When lowering of a couple of atomic intrinsics down to a loop structure, a FakeUse on the memory address's base variable is created. However, if the memory address is a global constant, there is no base variable. So check for that and don't create a FakeUse if there is none. BUG= none TEST=synchronization_sync (scons test) R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=27c56bf650197a019aede197c136a0fd9bb7692c

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -4 lines)			Patch
	M	src/IceTargetLoweringX8632.cpp	View		2 chunks	+6 lines, -4 lines	0 comments	Download
	M	tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll	View	1	5 chunks	+45 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

On 2015/03/23 16:27:04, jvoung wrote: > LGTM -- could you add a lit check too? ...

5 years, 9 months ago (2015-03-23 17:29:30 UTC) #4

Jim Stichnoth

5 years, 9 months ago (2015-03-23 17:30:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
27c56bf650197a019aede197c136a0fd9bb7692c (presubmit successful).