Issue 1023623002: Remove code whitelisting chrome://app-list/ for speech recognition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1023623002: Remove code whitelisting chrome://app-list/ for speech recognition. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)

Modified:
5 years, 9 months ago

Reviewers:
hans

CC:
chromium-reviews, tommi (sloooow) - chröme

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove code whitelisting chrome://app-list/ for speech recognition. BUG=439143 Committed: https://crrev.com/dbcd3d6b3551155406a5589841f1302f484e8214 Cr-Commit-Position: refs/heads/master@{#321481}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -10 lines)			Patch
	M	chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc	View		1 chunk	+1 line, -10 lines	0 comments	Download

Total messages: 7 (2 generated)

Anand Mistry (off Chromium)

The code that relies on this no longer works and is being removed.

5 years, 9 months ago (2015-03-19 06:54:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023623002/1

5 years, 9 months ago (2015-03-20 01:04:44 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-20 01:10:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dbcd3d6b3551155406a5589841f1302f484e8214
Cr-Commit-Position: refs/heads/master@{#321481}