Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1023623002: Remove code whitelisting chrome://app-list/ for speech recognition. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
Reviewers:
hans
CC:
chromium-reviews, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code whitelisting chrome://app-list/ for speech recognition. BUG=439143 Committed: https://crrev.com/dbcd3d6b3551155406a5589841f1302f484e8214 Cr-Commit-Position: refs/heads/master@{#321481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Mistry (off Chromium)
The code that relies on this no longer works and is being removed.
5 years, 9 months ago (2015-03-19 06:54:08 UTC) #2
hans
rs-lgtm
5 years, 9 months ago (2015-03-19 16:08:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023623002/1
5 years, 9 months ago (2015-03-20 01:04:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 01:09:29 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 01:10:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbcd3d6b3551155406a5589841f1302f484e8214
Cr-Commit-Position: refs/heads/master@{#321481}

Powered by Google App Engine
This is Rietveld 408576698