Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

Issue 1023623002: Remove code whitelisting chrome://app-list/ for speech recognition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
diff --git a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
index 267b9d2938f4f0d0aa44c008603912cd37f16e6b..f351079c8d69b16b80fd4d89280e0c5adfed30ef 100644
--- a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
+++ b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
@@ -416,17 +416,8 @@ void ChromeSpeechRecognitionManagerDelegate::CheckRenderViewType(
return;
}
- WebContents* web_contents = WebContents::FromRenderViewHost(render_view_host);
-
- // chrome://app-list/ uses speech recognition.
- if (web_contents->GetCommittedWebUI() &&
- web_contents->GetLastCommittedURL().spec() ==
- chrome::kChromeUIAppListStartPageURL) {
- allowed = true;
- check_permission = false;
- }
-
#if defined(ENABLE_EXTENSIONS)
+ WebContents* web_contents = WebContents::FromRenderViewHost(render_view_host);
extensions::ViewType view_type = extensions::GetViewType(web_contents);
if (view_type == extensions::VIEW_TYPE_TAB_CONTENTS ||
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698