Issue 1023203004: Limit QUIC's send algorithm max CWND by the peer's receive buffer and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1023203004: Limit QUIC's send algorithm max CWND by the peer's receive buffer and (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Improve_tests_88744988

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Limit QUIC's send algorithm max CWND by the peer's receive buffer and disable usage of the receive buffer in QuicSentPacketManager. Flag protected by FLAGS_quic_limit_max_cwnd_to_receive_buffer. Merge internal change: 88747441 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -3 lines)			Patch
M	net/quic/congestion_control/pacing_sender.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/congestion_control/pacing_sender.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/congestion_control/send_algorithm_interface.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_bytes_sender.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_bytes_sender.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 01:06:20 UTC) #4

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1023203004/1

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages