Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 1023203004: Limit QUIC's send algorithm max CWND by the peer's receive buffer and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Improve_tests_88744988
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index 1694da25415a1b5b1b198009716d601cb793f012..89f076877b28a3cd6efdf13b83fb5fc517bd93e2 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -172,6 +172,10 @@ void QuicSentPacketManager::SetFromConfig(const QuicConfig& config) {
receive_buffer_bytes_ =
max(kMinSocketReceiveBuffer,
static_cast<QuicByteCount>(config.ReceivedSocketReceiveBuffer()));
+ if (FLAGS_quic_limit_max_cwnd_to_receive_buffer) {
+ send_algorithm_->SetMaxCongestionWindow(receive_buffer_bytes_ *
+ kUsableRecieveBufferFraction);
+ }
}
send_algorithm_->SetFromConfig(config, perspective_, using_pacing_);
@@ -791,8 +795,9 @@ QuicTime::Delta QuicSentPacketManager::TimeUntilSend(
if (pending_timer_transmission_count_ > 0) {
return QuicTime::Delta::Zero();
}
- if (unacked_packets_.bytes_in_flight() >=
- kUsableRecieveBufferFraction * receive_buffer_bytes_) {
+ if (!FLAGS_quic_limit_max_cwnd_to_receive_buffer &&
+ unacked_packets_.bytes_in_flight() >=
+ kUsableRecieveBufferFraction * receive_buffer_bytes_) {
return QuicTime::Delta::Infinite();
}
return send_algorithm_->TimeUntilSend(
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698