Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1023113002: Web Audio: Change the argument of AudioNode::addOutput(). (Closed)

Created:
5 years, 9 months ago by tkent
Modified:
5 years, 9 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web Audio: Change the argument of AudioNode::addOutput(). This CL changes the argument of AudioNode::addOutput() from AudioNodeOutput* to number-of-channels, and AudioNode::addOutput() creates AudioNodeOutput object. This CL doesn't change user-visible behavior. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M Source/modules/webaudio/AudioBasicInspectorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioBasicProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/ChannelMergerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ChannelSplitterNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ConvolverNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/DynamicsCompressorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/GainNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/MediaStreamAudioSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OscillatorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/PannerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/StereoPannerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tkent
Please review this.
5 years, 9 months ago (2015-03-20 08:38:54 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-20 13:48:10 UTC) #3
Raymond Toy
lgtm Is this a general cleanup or is it required for splitting each class into ...
5 years, 9 months ago (2015-03-20 15:41:21 UTC) #4
tkent
> Is this a general cleanup or is it required for splitting each class into ...
5 years, 9 months ago (2015-03-21 08:38:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023113002/1
5 years, 9 months ago (2015-03-21 08:39:01 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-21 13:32:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192305

Powered by Google App Engine
This is Rietveld 408576698