Please review Patch Set #4. In addition to Satoru and Toni, I have added Aaron ...
8 years, 7 months ago
(2012-04-27 00:17:09 UTC)
#1
Please review Patch Set #4. In addition to Satoru and Toni, I have added Aaron
(owner of fileBrowserPrivate.json) and Robert (owner of file_manager.js) as
reviewers.
The intention is for file manager to display the user-friendly file name when
mounting archives on gdata. Previously the mounting works but the displayed name
is the long and garbled resource_id/md5 string.
In addition to applying the appropriate mount label, this change also sees that
AddMountFunction returns the source_path of the cache blob after it is moved to
"GCache/v1/persistent/<resource_id>.<md5>.mounted", so that it can match the
source_path in the MountPointInfo when DiskMountManager reports the mount
complete event. Otherwise the source path won't match, and we'll have dangling
entries in the file_manager.js list object "mountRequests_".
tbarzic
http://codereview.chromium.org/10231010/diff/20013/chrome/browser/chromeos/extensions/file_browser_event_router.cc File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right): http://codereview.chromium.org/10231010/diff/20013/chrome/browser/chromeos/extensions/file_browser_event_router.cc#newcode377 chrome/browser/chromeos/extensions/file_browser_event_router.cc:377: gdata::GDataFileSystem* file_system = This should probably be separate function. ...
8 years, 7 months ago
(2012-04-27 05:44:21 UTC)
#2
Presubmit check for 10231010-29005 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago
(2012-04-27 23:54:03 UTC)
#6
Presubmit check for 10231010-29005 failed and returned exit status 1.
Running presubmit commit checks ...
** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
chrome/common/extensions/api
Presubmit checks took 7.8s to calculate.
Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!
hshi
+ Mike (owner) to review change in chrome/common/extensions/api/
8 years, 7 months ago
(2012-04-28 00:04:38 UTC)
#7
+ Mike (owner) to review change in chrome/common/extensions/api/
miket_OOO
On 2012/04/28 00:04:38, hshi wrote: > + Mike (owner) to review change in chrome/common/extensions/api/ chrome/common/extensions/api/fileBrowserPrivate.json ...
8 years, 7 months ago
(2012-04-28 04:29:49 UTC)
#8
On 2012/04/28 00:04:38, hshi wrote:
> + Mike (owner) to review change in chrome/common/extensions/api/
chrome/common/extensions/api/fileBrowserPrivate.json LGTM. Did not review the
rest.
hshi
Satoru and Toni, may I have your LGTM on this issue too? Thank you.
8 years, 7 months ago
(2012-04-30 17:08:20 UTC)
#9
Satoru and Toni, may I have your LGTM on this issue too? Thank you.
satorux1
I defer to Toni. :)
8 years, 7 months ago
(2012-04-30 17:10:35 UTC)
#10
I defer to Toni. :)
tbarzic
lgtm http://codereview.chromium.org/10231010/diff/29005/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): http://codereview.chromium.org/10231010/diff/29005/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1024 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1024: mount_type)); send response before you try mounting
8 years, 7 months ago
(2012-04-30 17:20:40 UTC)
#11
Issue 10231010: gdata: Apply correct mount label when mounting archives in GData
(Closed)
Created 8 years, 7 months ago by hshi
Modified 2 years, 5 months ago
Reviewers: satorux1, tbarzic, Aaron Boodman, rginda, miket_OOO
Base URL: http://git.chromium.org/chromium/src.git@master
Comments: 14