pkg/csslib: fixes for args

pkg/csslib: fixes for args

R=jmesserly@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/csslib/commit/c9e74f1f7df295f9ee80663f994559cfb74fdbb8

[kevmoo, 2015-03-19 20:43:12]

kevmoo@google.com changed reviewers:
+ jmesserly@google.com, sigmund@google.com

[kevmoo, 2015-03-19 20:43:12]

Make csslib MUST thinner – less likely to introduce version lock

[Jennifer Messerly, 2015-03-19 20:57:18]

jmesserly@google.com changed reviewers:
+ rnystrom@google.com, terry@google.com

[Jennifer Messerly, 2015-03-19 20:57:18]

Hmmmm. This is kind of okay here, as I don't think csslib is commonly used
except as a library. But in general this is worrying. A library package can't
have a "bin" command it exposes, because potential version lock? It can't use
logging? What kind of world are we heading towards here.

For "args", if we had a distinction between packages used by the "bin" command
vs "lib", that might help ...

[Jennifer Messerly, 2015-03-19 20:58:44]

fyi: added terry@ as main author of csslib

[Siggi Cherem (dart-lang), 2015-03-19 20:59:33]

On 2015/03/19 20:57:18, John Messerly wrote:
> Hmmmm. This is kind of okay here, as I don't think csslib is commonly used
> except as a library. But in general this is worrying. A library package can't
> have a "bin" command it exposes, because potential version lock? It can't use
> logging? What kind of world are we heading towards here.
> 
> For "args", if we had a distinction between packages used by the "bin" command
> vs "lib", that might help ...

+1 - totally agree with John here.

[Sean Eagan, 2015-03-20 14:51:39]

On 2015/03/19 20:59:33, Siggi Cherem (dart-lang) wrote:
> On 2015/03/19 20:57:18, John Messerly wrote:
> > Hmmmm. This is kind of okay here, as I don't think csslib is commonly used
> > except as a library. But in general this is worrying. A library package
can't
> > have a "bin" command it exposes, because potential version lock? It can't
use
> > logging? What kind of world are we heading towards here.
> > 
> > For "args", if we had a distinction between packages used by the "bin"
command
> > vs "lib", that might help ...
> 
> +1 - totally agree with John here.

I filed an issue for that a while back:

http://dartbug.com/22054

but it was rejected :(

I ended up creating separate packages for my executable and library:

http://github.com/seaneagan/den
http://github.com/seaneagan/den_api

[kevmoo, 2015-04-03 01:23:08]

PTAL

[kevmoo, 2015-04-03 01:23:30]

Change CL title

[Jennifer Messerly, 2015-04-03 15:37:20]

lgtm!

[Bob Nystrom, 2015-04-03 16:15:24]

Couple nits, but LGTM.

Do you plan to make other changes before you publish this?

https://codereview.chromium.org/1022963002/diff/20001/example/call_parser.dart
File example/call_parser.dart (right):

https://codereview.chromium.org/1022963002/diff/20001/example/call_parser.dar...
example/call_parser.dart:19: {List errors, css.PreprocessorOptions opts}) =>
css.parse(cssInput,
This method is long enough that it should really use a {} body.

https://codereview.chromium.org/1022963002/diff/20001/lib/src/messages.dart
File lib/src/messages.dart (right):

https://codereview.chromium.org/1022963002/diff/20001/lib/src/messages.dart#n...
lib/src/messages.dart:128: .forEach((message) {
forEach(printHandler);

[kevmoo, 2015-04-03 16:31:25]

Could stand some more cleanup, but that can come later.

Going to push 0.12.0 now

https://codereview.chromium.org/1022963002/diff/20001/example/call_parser.dart
File example/call_parser.dart (right):

https://codereview.chromium.org/1022963002/diff/20001/example/call_parser.dar...
example/call_parser.dart:19: {List errors, css.PreprocessorOptions opts}) =>
css.parse(cssInput,
On 2015/04/03 16:15:24, Bob Nystrom wrote:
> This method is long enough that it should really use a {} body.

Done.

https://codereview.chromium.org/1022963002/diff/20001/lib/src/messages.dart
File lib/src/messages.dart (right):

https://codereview.chromium.org/1022963002/diff/20001/lib/src/messages.dart#n...
lib/src/messages.dart:128: .forEach((message) {
On 2015/04/03 16:15:24, Bob Nystrom wrote:
> forEach(printHandler);

Done.

[kevmoo, 2015-04-03 16:31:39]

Committed patchset #3 (id:40001) manually as
c9e74f1f7df295f9ee80663f994559cfb74fdbb8 (presubmit successful).