Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1022963002: pkg/csslib: fixes for args (Closed)

Created:
5 years, 9 months ago by kevmoo
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/csslib@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : another idea #

Total comments: 4

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -77 lines) Patch
M CHANGELOG.md View 1 1 chunk +7 lines, -0 lines 0 comments Download
M example/call_parser.dart View 1 2 1 chunk +11 lines, -6 lines 0 comments Download
M lib/parser.dart View 5 chunks +9 lines, -7 lines 0 comments Download
M lib/src/messages.dart View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M lib/src/options.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M test/big_1_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/compiler_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M test/declaration_test.dart View 18 chunks +18 lines, -22 lines 0 comments Download
M test/extend_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mixin_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/nested_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/testing.dart View 3 chunks +22 lines, -6 lines 0 comments Download
M test/var_test.dart View 5 chunks +4 lines, -10 lines 0 comments Download
M test/visitor_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
kevmoo
Make csslib MUST thinner – less likely to introduce version lock
5 years, 9 months ago (2015-03-19 20:43:12 UTC) #2
Jennifer Messerly
Hmmmm. This is kind of okay here, as I don't think csslib is commonly used ...
5 years, 9 months ago (2015-03-19 20:57:18 UTC) #4
Jennifer Messerly
fyi: added terry@ as main author of csslib
5 years, 9 months ago (2015-03-19 20:58:44 UTC) #5
Siggi Cherem (dart-lang)
On 2015/03/19 20:57:18, John Messerly wrote: > Hmmmm. This is kind of okay here, as ...
5 years, 9 months ago (2015-03-19 20:59:33 UTC) #6
Sean Eagan
On 2015/03/19 20:59:33, Siggi Cherem (dart-lang) wrote: > On 2015/03/19 20:57:18, John Messerly wrote: > ...
5 years, 9 months ago (2015-03-20 14:51:39 UTC) #7
kevmoo
PTAL
5 years, 8 months ago (2015-04-03 01:23:08 UTC) #8
kevmoo
Change CL title
5 years, 8 months ago (2015-04-03 01:23:30 UTC) #9
Jennifer Messerly
lgtm!
5 years, 8 months ago (2015-04-03 15:37:20 UTC) #10
Bob Nystrom
Couple nits, but LGTM. Do you plan to make other changes before you publish this? ...
5 years, 8 months ago (2015-04-03 16:15:24 UTC) #11
kevmoo
Could stand some more cleanup, but that can come later. Going to push 0.12.0 now ...
5 years, 8 months ago (2015-04-03 16:31:25 UTC) #12
kevmoo
5 years, 8 months ago (2015-04-03 16:31:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c9e74f1f7df295f9ee80663f994559cfb74fdbb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698