Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: test/testing.dart

Issue 1022963002: pkg/csslib: fixes for args (Closed) Base URL: https://github.com/dart-lang/csslib@master
Patch Set: nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/nested_test.dart ('k') | test/var_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/testing.dart
diff --git a/test/testing.dart b/test/testing.dart
index b9a6738f01817a7700679500fe89df71865fae65..df65532cef7815917fae0180f0f2e96b1502fdd6 100644
--- a/test/testing.dart
+++ b/test/testing.dart
@@ -8,6 +8,21 @@ library testing;
import 'package:csslib/parser.dart';
import 'package:csslib/visitor.dart';
import 'package:csslib/src/messages.dart';
+import 'package:csslib/src/options.dart';
+
+export 'package:csslib/src/options.dart';
+
+const simpleOptionsWithCheckedAndWarningsAsErrors = const PreprocessorOptions(
+ useColors: false,
+ checked: true,
+ warningsAsErrors: true,
+ inputFile: 'memory');
+
+const simpleOptions =
+ const PreprocessorOptions(useColors: false, inputFile: 'memory');
+
+const options = const PreprocessorOptions(
+ useColors: false, warningsAsErrors: true, inputFile: 'memory');
void useMockMessages() {
messages = new Messages(printHandler: (message) {});
@@ -19,10 +34,10 @@ void useMockMessages() {
* tests (by default) will ensure that the CSS is really valid.
*/
StyleSheet parseCss(String cssInput,
- {List<Message> errors, List<String> opts}) => parse(cssInput,
+ {List<Message> errors, PreprocessorOptions opts}) => parse(cssInput,
errors: errors,
options: opts == null
- ? ['--no-colors', '--checked', '--warnings_as_errors', 'memory']
+ ? simpleOptionsWithCheckedAndWarningsAsErrors
: opts);
/**
@@ -30,17 +45,18 @@ StyleSheet parseCss(String cssInput,
* CSS will allow any property/value pairs regardless of validity; all of our
* tests (by default) will ensure that the CSS is really valid.
*/
-StyleSheet compileCss(String cssInput, {List<Message> errors, List<String> opts,
- bool polyfill: false, List<StyleSheet> includes: null}) => compile(cssInput,
+StyleSheet compileCss(String cssInput, {List<Message> errors,
+ PreprocessorOptions opts, bool polyfill: false,
+ List<StyleSheet> includes: null}) => compile(cssInput,
errors: errors,
options: opts == null
- ? ['--no-colors', '--checked', '--warnings_as_errors', 'memory']
+ ? simpleOptionsWithCheckedAndWarningsAsErrors
: opts,
polyfill: polyfill,
includes: includes);
StyleSheet polyFillCompileCss(input,
- {List<Message> errors, List<String> opts}) =>
+ {List<Message> errors, PreprocessorOptions opts}) =>
compileCss(input, errors: errors, polyfill: true, opts: opts);
/** CSS emitter walks the style sheet tree and emits readable CSS. */
« no previous file with comments | « test/nested_test.dart ('k') | test/var_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698