src/lookup.h - Issue 1022943002: Cannot use Handle<T>::cast in Unique<T>::cast since it will try to do a T::cast (and its typecheck)…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.h

Issue 1022943002: Cannot use Handle<T>::cast in Unique<T>::cast since it will try to do a T::cast (and its typecheck)… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Locally allow handle deref Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.h

diff --git a/src/lookup.h b/src/lookup.h

index e2237abd63ac3d6fdf0ae9a443008576be39c6c0..f658b1382904c352d12e92b7f74b7dcac3ed6e65 100644

--- a/src/lookup.h

+++ b/src/lookup.h

@@ -138,10 +138,6 @@ class LookupIterator FINAL BASE_EMBEDDED {

int GetAccessorIndex() const;

int GetConstantIndex() const;

Handle<PropertyCell> GetPropertyCell() const;

- Handle<PropertyCell> GetTransitionPropertyCell() const {

- DCHECK_EQ(TRANSITION, state_);

- return Handle<PropertyCell>::cast(transition_);

- }

Handle<Object> GetAccessors() const;

Handle<Object> GetDataValue() const;

// Usually returns the value that was passed in, but may perform

« no previous file with comments | « src/bootstrapper.cc ('k') | src/lookup.cc » ('j') | no next file with comments »