Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3440)

Unified Diff: base/sys_info_win.cc

Issue 1022863002: Fix uninitialized read in base::SysInfo::HasSeekPenalty(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info_win.cc
diff --git a/base/sys_info_win.cc b/base/sys_info_win.cc
index 7c12524f15cd813771d2f7bb53b22cb22d821481..928ec478b6f9bcde92046a76634308bba49d21f2 100644
--- a/base/sys_info_win.cc
+++ b/base/sys_info_win.cc
@@ -85,6 +85,7 @@ bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) {
STORAGE_PROPERTY_QUERY query;
rvargas (doing something else) 2015/03/19 19:14:41 maybe = {} here instead? (it's kind of lame to hav
Dan Beam 2015/03/19 20:52:38 Done.
query.QueryType = PropertyStandardQuery;
query.PropertyId = StorageDeviceSeekPenaltyProperty;
+ query.AdditionalParameters = {};
DEVICE_SEEK_PENALTY_DESCRIPTOR result;
DWORD bytes_returned;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698