Fix uninitialized read in base::SysInfo::HasSeekPenalty().

base/sys_info_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_info.h"
 
 #include <windows.h>
 #include <winioctl.h>
 
 #include "base/files/file.h"
@@ skipping 64 matching lines @@
   if (win::GetVersion() < win::VERSION_WIN7)
     return false;
 
   std::vector<FilePath::StringType> components;
   path.GetComponents(&components);
 
   File drive(FilePath(L"\\\\.\\" + components[0]), File::FLAG_OPEN);
   if (!drive.IsValid())
     return false;
 
   STORAGE_PROPERTY_QUERY query;

[rvargas (doing something else), 2015/03/19 19:14:41]

maybe = {} here instead? (it's kind of lame to have to name unused fields to
make a tool happy).

[Dan Beam, 2015/03/19 20:52:38]

Done.

   query.QueryType = PropertyStandardQuery;
   query.PropertyId = StorageDeviceSeekPenaltyProperty;
+  query.AdditionalParameters = {};
 
   DEVICE_SEEK_PENALTY_DESCRIPTOR result;
   DWORD bytes_returned;
 
   BOOL success = DeviceIoControl(drive.GetPlatformFile(),
                                  IOCTL_STORAGE_QUERY_PROPERTY,
                                  &query, sizeof(query),
                                  &result, sizeof(result),
                                  &bytes_returned,
                                  NULL);
@@ skipping 58 matching lines @@
 void SysInfo::OperatingSystemVersionNumbers(int32* major_version,
                                             int32* minor_version,
                                             int32* bugfix_version) {
   win::OSInfo* os_info = win::OSInfo::GetInstance();
   *major_version = os_info->version_number().major;
   *minor_version = os_info->version_number().minor;
   *bugfix_version = 0;
 }
 
 }  // namespace base