Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1022863002: Fix uninitialized read in base::SysInfo::HasSeekPenalty(). (Closed)

Created:
5 years, 9 months ago by Dan Beam
Modified:
5 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized read in base::SysInfo::HasSeekPenalty(). R=rvargas@chromium.org BUG=468631 Committed: https://crrev.com/8349cde788d93f75c7e82d88c6bc44a43bc19cf5 Cr-Commit-Position: refs/heads/master@{#321445}

Patch Set 1 #

Total comments: 2

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/sys_info_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Dan Beam
5 years, 9 months ago (2015-03-19 18:23:45 UTC) #1
rvargas (doing something else)
lgtm https://codereview.chromium.org/1022863002/diff/1/base/sys_info_win.cc File base/sys_info_win.cc (right): https://codereview.chromium.org/1022863002/diff/1/base/sys_info_win.cc#newcode85 base/sys_info_win.cc:85: STORAGE_PROPERTY_QUERY query; maybe = {} here instead? (it's ...
5 years, 9 months ago (2015-03-19 19:14:41 UTC) #2
Dan Beam
https://codereview.chromium.org/1022863002/diff/1/base/sys_info_win.cc File base/sys_info_win.cc (right): https://codereview.chromium.org/1022863002/diff/1/base/sys_info_win.cc#newcode85 base/sys_info_win.cc:85: STORAGE_PROPERTY_QUERY query; On 2015/03/19 19:14:41, rvargas wrote: > maybe ...
5 years, 9 months ago (2015-03-19 20:52:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022863002/40001
5 years, 9 months ago (2015-03-19 20:53:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-19 22:02:44 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:03:13 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8349cde788d93f75c7e82d88c6bc44a43bc19cf5
Cr-Commit-Position: refs/heads/master@{#321445}

Powered by Google App Engine
This is Rietveld 408576698