[turbofan] Remove last_use_ field from Node.

test/unittests/compiler/node-properties-unittest.cc

Index: test/unittests/compiler/node-properties-unittest.cc
diff --git a/test/unittests/compiler/node-properties-unittest.cc b/test/unittests/compiler/node-properties-unittest.cc
index edaf430f8e690b2a39a2b6dc42afe2e592258e8b..ab8c9c7e58d3da749d72e63b96b16432de768fcd 100644
--- a/test/unittests/compiler/node-properties-unittest.cc
+++ b/test/unittests/compiler/node-properties-unittest.cc
@@ -32,6 +32,8 @@ const Operator kMockCallOperator(IrOpcode::kCall, Operator::kNoProperties,
 }  // namespace
 
 
+// TODO(titzer): These tests shouldn't depend on use list order.
+
 TEST_F(NodePropertiesTest, ReplaceWithValue_ValueUse) {
   CommonOperatorBuilder common(zone());
   Node* node = Node::New(zone(), 0, &kMockOperator, 0, nullptr, false);
@@ -56,7 +58,7 @@ TEST_F(NodePropertiesTest, ReplaceWithValue_EffectUse) {
   EXPECT_EQ(0, node->UseCount());
   EXPECT_EQ(2, start->UseCount());
   EXPECT_EQ(0, replacement->UseCount());
-  EXPECT_THAT(start->uses(), ElementsAre(node, use_effect));
+  EXPECT_THAT(start->uses(), ElementsAre(use_effect, node));

[Michael Starzinger, 2015/03/19 09:40:08]

Can we use UnorderedElementsAre here instead and address the TODO right away?

[titzer, 2015/03/19 10:10:31]

Done.

 }
 
 
@@ -72,7 +74,7 @@ TEST_F(NodePropertiesTest, ReplaceWithValue_ControlUse) {
   EXPECT_EQ(0, node->UseCount());
   EXPECT_EQ(2, start->UseCount());
   EXPECT_EQ(0, replacement->UseCount());
-  EXPECT_THAT(start->uses(), ElementsAre(node, use_control));
+  EXPECT_THAT(start->uses(), ElementsAre(use_control, node));

[Michael Starzinger, 2015/03/19 09:40:08]

Likewise.

[titzer, 2015/03/19 10:10:31]

Done.

 }