[turbofan] Remove last_use_ field from Node.

test/unittests/compiler/node-properties-unittest.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/common-operator.h"
 #include "src/compiler/node-properties.h"
 #include "test/unittests/test-utils.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
 using testing::AnyOf;
@@ skipping 14 matching lines @@
 const Operator kMockOpEffect(IrOpcode::kDead, Operator::kNoProperties,
                              "MockOpEffect", 0, 1, 0, 1, 1, 0);
 const Operator kMockOpControl(IrOpcode::kDead, Operator::kNoProperties,
                               "MockOpControl", 0, 0, 1, 1, 0, 1);
 const Operator kMockCallOperator(IrOpcode::kCall, Operator::kNoProperties,
                                  "MockCallOperator", 0, 0, 0, 0, 0, 2);
 
 }  // namespace
 
 
+// TODO(titzer): These tests shouldn't depend on use list order.
+
 TEST_F(NodePropertiesTest, ReplaceWithValue_ValueUse) {
   CommonOperatorBuilder common(zone());
   Node* node = Node::New(zone(), 0, &kMockOperator, 0, nullptr, false);
   Node* use_value = Node::New(zone(), 0, common.Return(), 1, &node, false);
   Node* replacement = Node::New(zone(), 0, &kMockOperator, 0, nullptr, false);
   NodeProperties::ReplaceWithValue(node, replacement);
   EXPECT_EQ(replacement, use_value->InputAt(0));
   EXPECT_EQ(0, node->UseCount());
   EXPECT_EQ(1, replacement->UseCount());
   EXPECT_THAT(replacement->uses(), ElementsAre(use_value));
 }
 
 
 TEST_F(NodePropertiesTest, ReplaceWithValue_EffectUse) {
   CommonOperatorBuilder common(zone());
   Node* start = Node::New(zone(), 0, common.Start(1), 0, nullptr, false);
   Node* node = Node::New(zone(), 0, &kMockOpEffect, 1, &start, false);
   Node* use_effect = Node::New(zone(), 0, common.EffectPhi(1), 1, &node, false);
   Node* replacement = Node::New(zone(), 0, &kMockOperator, 0, nullptr, false);
   NodeProperties::ReplaceWithValue(node, replacement);
   EXPECT_EQ(start, use_effect->InputAt(0));
   EXPECT_EQ(0, node->UseCount());
   EXPECT_EQ(2, start->UseCount());
   EXPECT_EQ(0, replacement->UseCount());
-  EXPECT_THAT(start->uses(), ElementsAre(node, use_effect));
+  EXPECT_THAT(start->uses(), ElementsAre(use_effect, node));

[Michael Starzinger, 2015/03/19 09:40:08]

Can we use UnorderedElementsAre here instead and address the TODO right away?

[titzer, 2015/03/19 10:10:31]

Done.

 }
 
 
 TEST_F(NodePropertiesTest, ReplaceWithValue_ControlUse) {
   CommonOperatorBuilder common(zone());
   Node* start = Node::New(zone(), 0, common.Start(1), 0, nullptr, false);
   Node* node = Node::New(zone(), 0, &kMockOpControl, 1, &start, false);
   Node* success = Node::New(zone(), 0, common.IfSuccess(), 1, &node, false);
   Node* use_control = Node::New(zone(), 0, common.Merge(1), 1, &success, false);
   Node* replacement = Node::New(zone(), 0, &kMockOperator, 0, nullptr, false);
   NodeProperties::ReplaceWithValue(node, replacement);
   EXPECT_EQ(start, use_control->InputAt(0));
   EXPECT_EQ(0, node->UseCount());
   EXPECT_EQ(2, start->UseCount());
   EXPECT_EQ(0, replacement->UseCount());
-  EXPECT_THAT(start->uses(), ElementsAre(node, use_control));
+  EXPECT_THAT(start->uses(), ElementsAre(use_control, node));

[Michael Starzinger, 2015/03/19 09:40:08]

Likewise.

[titzer, 2015/03/19 10:10:31]

Done.

 }
 
 
 TEST_F(NodePropertiesTest, FindProjection) {
   CommonOperatorBuilder common(zone());
   Node* start = Node::New(zone(), 0, common.Start(1), 0, nullptr, false);
   Node* proj0 = Node::New(zone(), 1, common.Projection(0), 1, &start, false);
   Node* proj1 = Node::New(zone(), 2, common.Projection(1), 1, &start, false);
   EXPECT_EQ(proj0, NodeProperties::FindProjection(start, 0));
   EXPECT_EQ(proj1, NodeProperties::FindProjection(start, 1));
@@ skipping 35 matching lines @@
   Node* if_value2 = Node::New(zone(), 4, common.IfValue(2), 1, &sw, false);
   NodeProperties::CollectControlProjections(sw, result, arraysize(result));
   EXPECT_THAT(result[0], AnyOf(if_value1, if_value2));
   EXPECT_THAT(result[1], AnyOf(if_value1, if_value2));
   EXPECT_EQ(if_default, result[2]);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8