Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1022703003: Cache Storage: Remove unused Service/Embedder Worker plumbing (Closed)

Created:
5 years, 9 months ago by jsbell
Modified:
5 years, 9 months ago
Reviewers:
kinuko, michaeln
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, jsbell+serviceworker_chromium.org, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@cache-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache Storage: Remove unused Service/Embedder Worker plumbing Follow up to https://codereview.chromium.org/1029423004 that cleans up the now-unused plumbing for the Cache Storage API routed through Service Worker and Embedded Worker classes. Service Workers and other contexts can access the API via the embedder API. BUG=439389 R=kinuko@chromium.org,michaeln@chromium.org Committed: https://crrev.com/c328fc4acba1b6b7760f4d81deed79b1d0d04c50 Cr-Commit-Position: refs/heads/master@{#322386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M content/renderer/service_worker/embedded_worker_context_client.h View 3 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jsbell
kinuko@, michaeln@ - please take a look? This can't land until http://crrev.com/1031063002 and http://crrev.com/1029423004 are ...
5 years, 9 months ago (2015-03-25 17:32:10 UTC) #1
michaeln
(+0 lines, -27 lines) lgtm!
5 years, 9 months ago (2015-03-25 19:04:29 UTC) #2
kinuko
lgtm yay~
5 years, 9 months ago (2015-03-25 23:53:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022703003/1
5 years, 9 months ago (2015-03-26 14:15:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 15:14:54 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 15:15:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c328fc4acba1b6b7760f4d81deed79b1d0d04c50
Cr-Commit-Position: refs/heads/master@{#322386}

Powered by Google App Engine
This is Rietveld 408576698