Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1022673007: Revert of remove colorfilter native-565 support. complicating w/ no real value. (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #2 id:20001 of https://codereview.chromium.org/1015533011/) Reason for revert: skia/ext/benchmarking_canvas.cc references HasFilter16 :( Original issue's description: > remove colorfilter native-565 support. complicating w/ no real value. > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710 TBR=reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/92b47c49016749249ff8521e424c4373b4a74241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -18 lines) Patch
M include/core/SkColorFilter.h View 1 chunk +19 lines, -3 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/effects/SkModeColorFilter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/SkColorFilter.cpp View 2 chunks +15 lines, -0 lines 0 comments Download
M src/core/SkFilterShader.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkFilterShader.cpp View 2 chunks +15 lines, -4 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 5 chunks +44 lines, -10 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
Created Revert of remove colorfilter native-565 support. complicating w/ no real value.
5 years, 9 months ago (2015-03-24 12:17:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022673007/1
5 years, 9 months ago (2015-03-24 12:18:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/92b47c49016749249ff8521e424c4373b4a74241
5 years, 9 months ago (2015-03-24 12:18:14 UTC) #3
reed1
5 years, 9 months ago (2015-03-24 13:35:01 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1016103004/ by reed@google.com.

The reason for reverting is: fix for chrome has landed....

Powered by Google App Engine
This is Rietveld 408576698