Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1022673002: Enable PDF plugin for iframes within the print preview dialog. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PDF plugin for iframes within the print preview dialog. BUG=465495 Committed: https://crrev.com/87a3217a2346be350204511735416f9b63ed7760 Cr-Commit-Position: refs/heads/master@{#321295}

Patch Set 1 #

Patch Set 2 : with test #

Total comments: 2

Patch Set 3 : nit #

Total comments: 1

Patch Set 4 : fix test #

Patch Set 5 : better comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -25 lines) Patch
M chrome/browser/printing/print_preview_dialog_controller.cc View 5 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 2 3 4 7 chunks +108 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 2 5 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Lei Zhang
5 years, 9 months ago (2015-03-19 01:38:16 UTC) #2
raymes
lgtm! thanks for adding the test. https://codereview.chromium.org/1022673002/diff/20001/chrome/browser/printing/print_view_manager.cc File chrome/browser/printing/print_view_manager.cc (right): https://codereview.chromium.org/1022673002/diff/20001/chrome/browser/printing/print_view_manager.cc#newcode48 chrome/browser/printing/print_view_manager.cc:48: pdf_plugin_path, &pdf_plugin)) nit: ...
5 years, 9 months ago (2015-03-19 02:14:33 UTC) #3
Lei Zhang
Let's see how the trybots react... https://codereview.chromium.org/1022673002/diff/20001/chrome/browser/printing/print_view_manager.cc File chrome/browser/printing/print_view_manager.cc (right): https://codereview.chromium.org/1022673002/diff/20001/chrome/browser/printing/print_view_manager.cc#newcode48 chrome/browser/printing/print_view_manager.cc:48: pdf_plugin_path, &pdf_plugin)) On ...
5 years, 9 months ago (2015-03-19 02:20:09 UTC) #4
Lei Zhang
https://codereview.chromium.org/1022673002/diff/40001/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc File chrome/browser/printing/print_preview_dialog_controller_browsertest.cc (right): https://codereview.chromium.org/1022673002/diff/40001/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc#newcode280 chrome/browser/printing/print_preview_dialog_controller_browsertest.cc:280: ASSERT_TRUE(GetPdfPluginInfo(&pdf_plugin_info)); This failed on the CrOS bot. I'm pretty ...
5 years, 9 months ago (2015-03-19 02:55:34 UTC) #5
Lei Zhang
I think patch set 5 should do the trick. Try bots activate!
5 years, 9 months ago (2015-03-19 03:26:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022673002/80001
5 years, 9 months ago (2015-03-19 04:44:03 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-19 04:48:19 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 04:48:49 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/87a3217a2346be350204511735416f9b63ed7760
Cr-Commit-Position: refs/heads/master@{#321295}

Powered by Google App Engine
This is Rietveld 408576698