chrome/browser/printing/print_view_manager.h - Issue 1022673002: Enable PDF plugin for iframes within the print preview dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager.h

Issue 1022673002: Enable PDF plugin for iframes within the print preview dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_dialog_controller_browsertest.cc ('k') | chrome/browser/printing/print_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_view_manager.h

diff --git a/chrome/browser/printing/print_view_manager.h b/chrome/browser/printing/print_view_manager.h

index aea5d8345bbeefcff0f990a13c7efcf826d774d9..45e840b54c97aa45550ae4ec529b738c96036ff9 100644

--- a/chrome/browser/printing/print_view_manager.h

+++ b/chrome/browser/printing/print_view_manager.h

@@ -56,6 +56,9 @@ class PrintViewManager : public PrintViewManagerBase,

bool OnMessageReceived(const IPC::Message& message) override;

// content::WebContentsObserver implementation.

+ void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;

+ // content::WebContentsObserver implementation.

// Terminates or cancels the print job if one was pending.

void RenderProcessGone(base::TerminationStatus status) override;