Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: extensions/browser/api/socket/app_firewall_hole_manager.h

Issue 1022663003: Bind open firewall ports to visible application windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually fix the GN build. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/BUILD.gn ('k') | extensions/browser/api/socket/app_firewall_hole_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/socket/app_firewall_hole_manager.h
diff --git a/extensions/browser/api/socket/app_firewall_hole_manager.h b/extensions/browser/api/socket/app_firewall_hole_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..6fa3870dc5dd5f9297c9867251f01234e6bd3ae7
--- /dev/null
+++ b/extensions/browser/api/socket/app_firewall_hole_manager.h
@@ -0,0 +1,96 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_API_SOCKET_APP_FIREWALL_HOLE_MANAGER_H_
+#define EXTENSIONS_BROWSER_API_SOCKET_APP_FIREWALL_HOLE_MANAGER_H_
+
+#include <map>
+
+#include "base/scoped_observer.h"
+#include "chromeos/network/firewall_hole.h"
+#include "extensions/browser/app_window/app_window_registry.h"
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+
+class AppFirewallHoleManager;
+
+// Represents an open port in the system firewall that will be opened and closed
+// automatically when the application has a visible window or not. The hole is
+// closed on destruction.
+class AppFirewallHole {
+ public:
+ typedef chromeos::FirewallHole::PortType PortType;
+
+ ~AppFirewallHole();
+
+ PortType type() const { return type_; }
+ uint16_t port() const { return port_; }
+ const std::string& extension_id() const { return extension_id_; }
+
+ private:
+ friend class AppFirewallHoleManager;
+
+ AppFirewallHole(AppFirewallHoleManager* manager,
+ PortType type,
+ uint16_t port,
+ const std::string& extension_id);
+
+ void SetVisible(bool app_visible);
+ void OnFirewallHoleOpened(scoped_ptr<chromeos::FirewallHole> firewall_hole);
+
+ PortType type_;
+ uint16_t port_;
+ std::string extension_id_;
+ bool app_visible_ = false;
+
+ // This object is destroyed when the AppFirewallHoleManager that owns it is
+ // destroyed and so a raw pointer is okay here.
+ AppFirewallHoleManager* manager_;
+
+ // This will hold the FirewallHole object if one is opened.
+ scoped_ptr<chromeos::FirewallHole> firewall_hole_;
+
+ base::WeakPtrFactory<AppFirewallHole> weak_factory_;
+};
+
+// Tracks ports in the system firewall opened by an application so that they
+// may be automatically opened and closed only when the application has a
+// visible window.
+class AppFirewallHoleManager : public KeyedService,
+ public AppWindowRegistry::Observer {
+ public:
+ explicit AppFirewallHoleManager(content::BrowserContext* context);
+ ~AppFirewallHoleManager() override;
+
+ // Returns the instance for a given browser context, or NULL if none.
+ static AppFirewallHoleManager* Get(content::BrowserContext* context);
+
+ // Takes ownership of the AppFirewallHole and will open a port on the system
+ // firewall if the associated application is currently visible.
+ scoped_ptr<AppFirewallHole> Open(AppFirewallHole::PortType type,
+ uint16_t port,
+ const std::string& extension_id);
+
+ private:
+ friend class AppFirewallHole;
+
+ void Close(AppFirewallHole* hole);
+
+ // AppWindowRegistry::Observer
+ void OnAppWindowRemoved(AppWindow* app_window) override;
+ void OnAppWindowHidden(AppWindow* app_window) override;
+ void OnAppWindowShown(AppWindow* app_window, bool was_hidden) override;
+
+ content::BrowserContext* context_;
+ ScopedObserver<AppWindowRegistry, AppWindowRegistry::Observer> observer_;
+ std::multimap<std::string, AppFirewallHole*> tracked_holes_;
+};
+
+} // namespace extensions
+
+#endif // EXTENSIONS_BROWSER_API_SOCKET_APP_FIREWALL_HOLE_MANAGER_H_
« no previous file with comments | « extensions/BUILD.gn ('k') | extensions/browser/api/socket/app_firewall_hole_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698