extensions/BUILD.gn - Issue 1022663003: Bind open firewall ports to visible application windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/BUILD.gn

Issue 1022663003: Bind open firewall ports to visible application windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually fix the GN build. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/BUILD.gn

diff --git a/extensions/BUILD.gn b/extensions/BUILD.gn

index 39bc1b885f3eebc9b567d2fc192efe4c1c3d9ea4..ad3960a5c44cbd4fb839a6fe5f580b783bec0d41 100644

--- a/extensions/BUILD.gn

+++ b/extensions/BUILD.gn

@@ -138,9 +138,6 @@ test("extensions_unittests") {

# TODO(rockot): DisplayInfoProvider::Create() is only implemented in Chrome

# and app_shell. This is wrong.

"shell/browser/shell_display_info_provider.cc",

- # TODO(rockot): See above, but the header is in //components.

- "shell/browser/shell_web_contents_modal_dialog_manager.cc",

]

deps = [

« no previous file with comments | « no previous file | extensions/browser/api/socket/app_firewall_hole_manager.h » ('j') | no next file with comments »