Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 102263006: Implement HTMLOptionElement.form as required by spec. (Closed)

Created:
7 years ago by sof
Modified:
7 years ago
CC:
blink-reviews, watchdog-blink-watchlist_google.com, dglazkov+blink, arv+blink, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement HTMLOptionElement.form as required by spec. The spec tells us that an option element http://www.whatwg.org/specs/web-apps/current-work//#dom-option-form only has a form value if inside a <select>. Implement this. R=arv@chromium.org BUG=324828 TEST=fast/forms/form-attribute Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163671

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M LayoutTests/fast/forms/form-attribute.html View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/form-attribute-expected.txt View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +9 lines, -0 lines 1 comment Download
M Source/core/html/HTMLOptionElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
sof
At your leisure, please take a look. [CL 2 (of 3) from https://codereview.chromium.org/107183004/ ]
7 years ago (2013-12-10 11:24:22 UTC) #1
sof
On 2013/12/10 11:24:22, sof wrote: > At your leisure, please take a look. > > ...
7 years ago (2013-12-10 13:03:04 UTC) #2
arv (Not doing code reviews)
LGTM
7 years ago (2013-12-10 20:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/102263006/1
7 years ago (2013-12-10 21:05:26 UTC) #4
tkent
lgtm https://codereview.chromium.org/102263006/diff/1/Source/core/html/HTMLOptionElement.cpp File Source/core/html/HTMLOptionElement.cpp (right): https://codereview.chromium.org/102263006/diff/1/Source/core/html/HTMLOptionElement.cpp#newcode371 Source/core/html/HTMLOptionElement.cpp:371: HTMLSelectElement* selectElement = ownerSelectElement(); nit: if (HTMLSelectElement* selectElement ...
7 years ago (2013-12-10 23:09:07 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years ago (2013-12-10 23:22:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/102263006/1
7 years ago (2013-12-11 05:18:55 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-11 05:19:13 UTC) #8
Message was sent while issue was closed.
Change committed as 163671

Powered by Google App Engine
This is Rietveld 408576698