Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6890)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 1022543002: [chromedriver] Implement DELETE NetworkConditions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/server/http_handler.cc ('k') | chrome/test/chromedriver/window_commands.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 57e199000e6b0f59f0a4c710ca74aca512b2fc7b..8d166c564505f8ecaf03cdf52e3edc98f8a6c75c 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -811,6 +811,14 @@ class ChromeDriverTest(ChromeDriverBaseTest):
self.assertEquals(throughput, network['upload_throughput']);
self.assertEquals(False, network['offline']);
+ self._driver.DeleteNetworkConditions()
+
+ network = self._driver.GetNetworkConditions()
+ self.assertEquals(0, network['latency']);
+ self.assertLess(network['download_throughput'], 0);
+ self.assertLess(network['upload_throughput'], 0);
+ self.assertEquals(False, network['offline']);
samuong 2015/03/18 17:58:43 should this return a zeroed-out dictionary, or a "
srawlins 2015/03/18 18:24:25 Yeah I can refactor this to delete the overriddenN
samuong 2015/03/18 18:32:23 I'm OK with either, but I think that if a user per
+
def testEmulateNetworkConditionsName(self):
# DSL: 2Mbps throughput, 5ms RTT
#latency = 5
« no previous file with comments | « chrome/test/chromedriver/server/http_handler.cc ('k') | chrome/test/chromedriver/window_commands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698