[chromedriver] Implement DELETE NetworkConditions

chrome/test/chromedriver/test/run_py_tests.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """End to end tests for ChromeDriver."""
 
 import base64
 import json
 import math
@@ skipping 793 matching lines @@
     latency = 5
     throughput = 2048 * 1024
     self._driver.SetNetworkConditions(latency, throughput, throughput)
 
     network = self._driver.GetNetworkConditions()
     self.assertEquals(latency, network['latency']);
     self.assertEquals(throughput, network['download_throughput']);
     self.assertEquals(throughput, network['upload_throughput']);
     self.assertEquals(False, network['offline']);
 
+    self._driver.DeleteNetworkConditions()
+
+    network = self._driver.GetNetworkConditions()
+    self.assertEquals(0, network['latency']);
+    self.assertLess(network['download_throughput'], 0);
+    self.assertLess(network['upload_throughput'], 0);
+    self.assertEquals(False, network['offline']);

[samuong, 2015/03/18 17:58:43]

should this return a zeroed-out dictionary, or a "network conditions must be set
before it can be retrieved" error?

[srawlins, 2015/03/18 18:24:25]

Yeah I can refactor this to delete the overriddenNetworkConditions in the
session.

What would you prefer? I'm fine with... an empty dictionary. I think that might
be friendliest.

[samuong, 2015/03/18 18:32:23]

I'm OK with either, but I think that if a user performs the following steps, it
should return the same thing in steps 2 and 5:

1. create session
2. get network conditions
3. set network conditions to something else
4. delete network conditions
5. get network conditions

If I'm reading correctly, ExecuteGetNetworkConditions() currently returns an
error in this case?

+
   def testEmulateNetworkConditionsName(self):
     # DSL: 2Mbps throughput, 5ms RTT
     #latency = 5
     #throughput = 2048 * 1024
     self._driver.SetNetworkConditionsName('DSL')
 
     network = self._driver.GetNetworkConditions()
     self.assertEquals(5, network['latency']);
     self.assertEquals(2048*1024, network['download_throughput']);
     self.assertEquals(2048*1024, network['upload_throughput']);
@@ skipping 714 matching lines @@
 
   all_tests_suite = unittest.defaultTestLoader.loadTestsFromModule(
       sys.modules[__name__])
   tests = unittest_util.FilterTestSuite(all_tests_suite, options.filter)
   ChromeDriverTest.GlobalSetUp()
   MobileEmulationCapabilityTest.GlobalSetUp()
   result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(tests)
   ChromeDriverTest.GlobalTearDown()
   MobileEmulationCapabilityTest.GlobalTearDown()
   sys.exit(len(result.failures) + len(result.errors))