[chromedriver] Implement DELETE NetworkConditions

chrome/test/chromedriver/test/run_py_tests.py

Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 57e199000e6b0f59f0a4c710ca74aca512b2fc7b..8d166c564505f8ecaf03cdf52e3edc98f8a6c75c 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -811,6 +811,14 @@ class ChromeDriverTest(ChromeDriverBaseTest):
     self.assertEquals(throughput, network['upload_throughput']);
     self.assertEquals(False, network['offline']);
 
+    self._driver.DeleteNetworkConditions()
+
+    network = self._driver.GetNetworkConditions()
+    self.assertEquals(0, network['latency']);
+    self.assertLess(network['download_throughput'], 0);
+    self.assertLess(network['upload_throughput'], 0);
+    self.assertEquals(False, network['offline']);

[samuong, 2015/03/18 17:58:43]

should this return a zeroed-out dictionary, or a "network conditions must be set
before it can be retrieved" error?

[srawlins, 2015/03/18 18:24:25]

Yeah I can refactor this to delete the overriddenNetworkConditions in the
session.

What would you prefer? I'm fine with... an empty dictionary. I think that might
be friendliest.

[samuong, 2015/03/18 18:32:23]

I'm OK with either, but I think that if a user performs the following steps, it
should return the same thing in steps 2 and 5:

1. create session
2. get network conditions
3. set network conditions to something else
4. delete network conditions
5. get network conditions

If I'm reading correctly, ExecuteGetNetworkConditions() currently returns an
error in this case?

+
   def testEmulateNetworkConditionsName(self):
     # DSL: 2Mbps throughput, 5ms RTT
     #latency = 5