[Webapp Refactor] Move key injection logic into the plugin layer.

[Webapp Refactor] Move key injection related functionality into the plugin layer.

This CL moves key injection logic setRemapKey() and injectKeyCombination() into
the plugin layer.

With this change, we no longer need to pass the default remap keys from the
ApplicationDelegate through the SessionConnector to the DesktopConnectedView
in order to setup a key remapping.

Instead, we can simply call plugin.setRemapKeys('a->b,b->c') on the delegate.

BUG=465878
Committed: https://crrev.com/06408c1d57d6521cc1acebccbdb4972d2a26ae41
Cr-Commit-Position: refs/heads/master@{#321419}

[kelvinp, 2015-03-19 00:23:02]

kelvinp@chromium.org changed reviewers:
+ garykac@chromium.org

[kelvinp, 2015-03-19 00:25:15]

PTAL

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
File remoting/webapp/crd/js/client_plugin_impl.js (right):

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin_impl.js:505:
remoting.ClientPluginImpl.prototype.setRemapKeys =
moved from desktop_connected_view.js

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/desk...
File remoting/webapp/crd/js/desktop_connected_view.js (left):

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/desk...
remoting/webapp/crd/js/desktop_connected_view.js:261:
remoting.DesktopConnectedView.prototype.setRemapKeys = function(remappings) {
Moved to client_plugin_impl.js

[garykac, 2015-03-19 01:20:58]

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
File remoting/webapp/crd/js/client_plugin.js (right):

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin.js:58:
remoting.ClientPlugin.prototype.injectKeyCombination = function(keys) {};
This is only used internally and doesn't need to be part of the interface.

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
File remoting/webapp/crd/js/client_plugin_impl.js (right):

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin_impl.js:518: */
nit: add @private

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin_impl.js:557:
remoting.ClientPluginImpl.prototype.injectKeyCombination =
nit: This is @private and should have an underscore at the end of the function
name

[kelvinp, 2015-03-19 17:28:20]

PTAL

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
File remoting/webapp/crd/js/client_plugin.js (right):

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin.js:58:
remoting.ClientPlugin.prototype.injectKeyCombination = function(keys) {};
On 2015/03/19 01:20:57, garykac wrote:
> This is only used internally and doesn't need to be part of the interface.

This is referenced in DesktopConnectedView.sendCtrlAltDel

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
File remoting/webapp/crd/js/client_plugin_impl.js (right):

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin_impl.js:518: */
On 2015/03/19 01:20:57, garykac wrote:
> nit: add @private

Done.

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin_impl.js:557:
remoting.ClientPluginImpl.prototype.injectKeyCombination =
On 2015/03/19 01:20:57, garykac wrote:
> nit: This is @private and should have an underscore at the end of the function
> name

This is not a private. Referenced in DestopConnectedView.sendCtrlAltDel

[garykac, 2015-03-19 17:53:25]

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
File remoting/webapp/crd/js/client_plugin_impl.js (right):

https://codereview.chromium.org/1022473004/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_plugin_impl.js:557:
remoting.ClientPluginImpl.prototype.injectKeyCombination =
On 2015/03/19 17:28:20, kelvinp wrote:
> On 2015/03/19 01:20:57, garykac wrote:
> > nit: This is @private and should have an underscore at the end of the
function
> > name
> 
> This is not a private. Referenced in DestopConnectedView.sendCtrlAltDel

The comment blocks her says that it is @private.

I'm guessing that jscompile doesn't complain because the interface does not have
@private.

[kelvinp, 2015-03-19 18:02:22]

PTAL

[garykac, 2015-03-19 18:19:37]

lgtm

[kelvinp, 2015-03-19 18:26:35]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-03-19 18:26:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1022473004/40001

[commit-bot: I haz the power, 2015-03-19 20:21:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-19 20:22:20]

Patchset 3 (id:??) landed as
https://crrev.com/06408c1d57d6521cc1acebccbdb4972d2a26ae41
Cr-Commit-Position: refs/heads/master@{#321419}