Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: remoting/webapp/crd/js/session_connector_impl.js

Issue 1022473004: [Webapp Refactor] Move key injection logic into the plugin layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removes mismatched privates Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/session_connector.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/session_connector_impl.js
diff --git a/remoting/webapp/crd/js/session_connector_impl.js b/remoting/webapp/crd/js/session_connector_impl.js
index 9e3f67c3b153e23253549b0a2e62eaff0063a165..427d6a3f4bb88199299bc5ee5b6ecf3a2cd84165 100644
--- a/remoting/webapp/crd/js/session_connector_impl.js
+++ b/remoting/webapp/crd/js/session_connector_impl.js
@@ -28,15 +28,12 @@ remoting.clientSession = null;
* the connection fails.
* @param {Array<string>} requiredCapabilities Connector capabilities
* required by this application.
- * @param {string} defaultRemapKeys The default set of key mappings for the
- * client session to use.
* @constructor
* @implements {remoting.SessionConnector}
*/
remoting.SessionConnectorImpl = function(clientContainer, onConnected, onError,
onConnectionFailed,
- requiredCapabilities,
- defaultRemapKeys) {
+ requiredCapabilities) {
/** @private {HTMLElement} */
this.clientContainer_ = clientContainer;
@@ -52,9 +49,6 @@ remoting.SessionConnectorImpl = function(clientContainer, onConnected, onError,
/** @private {Array<string>} */
this.requiredCapabilities_ = requiredCapabilities;
- /** @private {string} */
- this.defaultRemapKeys_ = defaultRemapKeys;
-
/** @private {remoting.DesktopConnectedView.Mode} */
this.connectionMode_ = remoting.DesktopConnectedView.Mode.ME2ME;
@@ -555,16 +549,13 @@ remoting.DefaultSessionConnectorFactory = function() {};
* the connection fails.
* @param {Array<string>} requiredCapabilities Connector capabilities
* required by this application.
- * @param {string} defaultRemapKeys The default set of key mappings to use
- * in the client session.
* @return {remoting.SessionConnector}
*/
remoting.DefaultSessionConnectorFactory.prototype.createConnector =
function(clientContainer, onConnected, onError,
- onConnectionFailed, requiredCapabilities, defaultRemapKeys) {
+ onConnectionFailed, requiredCapabilities) {
return new remoting.SessionConnectorImpl(clientContainer, onConnected,
onError,
onConnectionFailed,
- requiredCapabilities,
- defaultRemapKeys);
+ requiredCapabilities);
};
« no previous file with comments | « remoting/webapp/crd/js/session_connector.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698