Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chromeos/network/network_state_handler.cc

Issue 1022333002: Initial CL for Data Saver (Flywheel) prompt when cellular network detected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from two reviewers Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_handler.cc
diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc
index a3aca7cd658ee8ad372d6cd6552fc6d243302d08..d6866c09e1850b4d42b3bcc3358011d793d640f3 100644
--- a/chromeos/network/network_state_handler.cc
+++ b/chromeos/network/network_state_handler.cc
@@ -5,6 +5,7 @@
#include "chromeos/network/network_state_handler.h"
#include "base/bind.h"
+#include "base/command_line.h"
#include "base/format_macros.h"
#include "base/guid.h"
#include "base/json/json_string_value_serializer.h"
@@ -16,6 +17,7 @@
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
+#include "chromeos/chromeos_switches.h"
#include "chromeos/network/device_state.h"
#include "chromeos/network/network_event_log.h"
#include "chromeos/network/network_state.h"
@@ -87,6 +89,17 @@ NetworkStateHandler* NetworkStateHandler::InitializeForTest() {
return handler;
}
+void NetworkStateHandler::DebugNotifyNetworkPropertiesUpdated() {
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ chromeos::switches::kEnableDataSaverPrompt))
+ return;
+
+ NetworkState network(NetworkStateHandlerObserver::kDebugDataSaverNetworkPath);
+ base::StringValue val(shill::kTypeCellular);
+ network.PropertyChanged("Type", val);
+ NotifyNetworkPropertiesUpdated(&network);
stevenjb 2015/03/25 17:57:08 I don't like putting debug code like this in Netwo
Greg Levin 2015/04/03 18:28:37 Done (code removed).
+}
+
void NetworkStateHandler::AddObserver(
NetworkStateHandlerObserver* observer,
const tracked_objects::Location& from_here) {

Powered by Google App Engine
This is Rietveld 408576698