Initial CL for Data Saver (Flywheel) prompt when cellular network detected

chromeos/network/network_state_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_state_handler.h"
 
 #include "base/bind.h"
+#include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/guid.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/json/json_writer.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
+#include "chromeos/chromeos_switches.h"
 #include "chromeos/network/device_state.h"
 #include "chromeos/network/network_event_log.h"
 #include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler_observer.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 
 namespace {
 
@@ skipping 51 matching lines @@
   shill_property_handler_->Init();
 }
 
 // static
 NetworkStateHandler* NetworkStateHandler::InitializeForTest() {
   NetworkStateHandler* handler = new NetworkStateHandler();
   handler->InitShillPropertyHandler();
   return handler;
 }
 
+void NetworkStateHandler::DebugNotifyNetworkPropertiesUpdated() {
+  if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+          chromeos::switches::kEnableDataSaverPrompt))
+    return;
+
+  NetworkState network(NetworkStateHandlerObserver::kDebugDataSaverNetworkPath);
+  base::StringValue val(shill::kTypeCellular);
+  network.PropertyChanged("Type", val);
+  NotifyNetworkPropertiesUpdated(&network);

[stevenjb, 2015/03/25 17:57:08]

I don't like putting debug code like this in NetworkStateHandler. It seems like
this could be handled entirely in the promo notification code. See also my high
level comment.

[Greg Levin, 2015/04/03 18:28:37]

Done (code removed).

+}
+
 void NetworkStateHandler::AddObserver(
     NetworkStateHandlerObserver* observer,
     const tracked_objects::Location& from_here) {
   observers_.AddObserver(observer);
   device_event_log::AddEntry(from_here.file_name(), from_here.line_number(),
                              device_event_log::LOG_TYPE_NETWORK,
                              device_event_log::LOG_LEVEL_DEBUG,
                              "NetworkStateHandler::AddObserver");
 }
 
@@ skipping 866 matching lines @@
   if (type.MatchesType(shill::kTypeBluetooth))
     technologies.push_back(new std::string(shill::kTypeBluetooth));
   if (type.MatchesType(shill::kTypeVPN))
     technologies.push_back(new std::string(shill::kTypeVPN));
 
   CHECK_GT(technologies.size(), 0ul);
   return technologies.Pass();
 }
 
 }  // namespace chromeos