Add a cancel button to the details panel...visible when import is active.

Add a cancel button to the details panel...visible when import is active.

TEST=*ImportControllerTest
TBR=cpu  // for strings changes

Committed: https://crrev.com/b0ce17d8bd3d8608f06661d230c159f71ac80081
Cr-Commit-Position: refs/heads/master@{#321796}

[Steve McKay, 2015-03-20 23:06:07]

smckay@chromium.org changed reviewers:
+ mtomasz@chromium.org

[Steve McKay, 2015-03-20 23:11:07]

Self review

[mtomasz, 2015-03-23 00:28:36]

Basically lgtm with two questions.

https://codereview.chromium.org/1022213002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
(right):

https://codereview.chromium.org/1022213002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller_unittest.html:9:
<script
src="../../../../../third_party/analytics/google-analytics-bundle.js"></script>
Are we registering and uploading analytics hits when running tests?

https://codereview.chromium.org/1022213002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/1022213002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/main.html:405: <paper-button class="cancel"
tabindex="-1">
nit: Why tabindex is -1?

[Steve McKay, 2015-03-23 16:20:49]

Thanks.

https://codereview.chromium.org/1022213002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
(right):

https://codereview.chromium.org/1022213002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller_unittest.html:9:
<script
src="../../../../../third_party/analytics/google-analytics-bundle.js"></script>
On 2015/03/23 00:28:36, mtomasz wrote:
> Are we registering and uploading analytics hits when running tests?

Nope. We install a test tracker. But there are other object (like the
EventBuilder) that don't have (or are suitable candidates for) test doubles.

https://codereview.chromium.org/1022213002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/1022213002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/main.html:405: <paper-button class="cancel"
tabindex="-1">
On 2015/03/23 00:28:36, mtomasz wrote:
> nit: Why tabindex is -1?

Currently we excluded details panel from tab access. We'll eventually want to
make the panel accessible, but not right now. Primary functionality  is
accessible via the toolbar buttons.

[Steve McKay, 2015-03-23 16:21:14]

The CQ bit was checked by smckay@chromium.org

[commit-bot: I haz the power, 2015-03-23 16:21:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1022213002/20001

[commit-bot: I haz the power, 2015-03-23 17:03:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-23 17:03:44]

Patchset 2 (id:??) landed as
https://crrev.com/b0ce17d8bd3d8608f06661d230c159f71ac80081
Cr-Commit-Position: refs/heads/master@{#321796}