ui/file_manager/file_manager/common/js/metrics_events.js - Issue 1022213002: Add a cancel button to the details panel...visible when import is active.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/common/js/metrics_events.js

Issue 1022213002: Add a cancel button to the details panel...visible when import is active. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/background/js/media_import_handler.js ('k') | ui/file_manager/file_manager/foreground/css/file_manager.css » ('j') | ui/file_manager/file_manager/foreground/js/import_controller_unittest.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/common/js/metrics_events.js

diff --git a/ui/file_manager/file_manager/common/js/metrics_events.js b/ui/file_manager/file_manager/common/js/metrics_events.js

index f801cde840495188e6532adf7036d4c8e3b6247b..5b3bdbeb46b1cd54630af0825252de2608dcef5b 100644

--- a/ui/file_manager/file_manager/common/js/metrics_events.js

+++ b/ui/file_manager/file_manager/common/js/metrics_events.js

@@ -77,31 +77,31 @@ metrics.event.Builders_ = {

* @enum {!analytics.EventBuilder}

metrics.ImportEvents = {

- STARTED: metrics.event.Builders_.IMPORT

- .action('Import Started')

- .dimension(metrics.Dimensions.SESSION_TYPE_IMPORT)

- .dimension(metrics.Dimensions.CONSUMER_TYPE_IMPORTER),

- CANCELLED: metrics.event.Builders_.IMPORT

- .action('Import Cancelled'),

+ DEVICE_YANKED: metrics.event.Builders_.IMPORT

+ .action('Device Yanked'),

ERRORS: metrics.event.Builders_.IMPORT

.action('Import Error Count'),

+ FILES_DEDUPLICATED: metrics.event.Builders_.IMPORT

+ .action('Files Deduplicated'),

FILES_IMPORTED: metrics.event.Builders_.IMPORT

.action('Files Imported'),

- MEGABYTES_IMPORTED: metrics.event.Builders_.IMPORT

- .action('Megabytes Imported'),

+ HISTORY_LOADED: metrics.event.Builders_.IMPORT

+ .action('History Loaded'),

- DEVICE_YANKED: metrics.event.Builders_.IMPORT

- .action('Device Yanked'),

+ IMPORT_CANCELLED: metrics.event.Builders_.IMPORT

+ .action('Import Cancelled'),

- FILES_DEDUPLICATED: metrics.event.Builders_.IMPORT

- .action('Files Deduplicated'),

+ MEGABYTES_IMPORTED: metrics.event.Builders_.IMPORT

+ .action('Megabytes Imported'),

- HISTORY_LOADED: metrics.event.Builders_.IMPORT

- .action('History Loaded')

+ STARTED: metrics.event.Builders_.IMPORT

+ .action('Import Started')

+ .dimension(metrics.Dimensions.SESSION_TYPE_IMPORT)

+ .dimension(metrics.Dimensions.CONSUMER_TYPE_IMPORTER)

};

// namespace