Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Issue 1022113002: Revert of Removed arbitrary 4096 size limit on WebGL canvas backbuffers (Closed)

Created:
5 years, 9 months ago by Corentin Wallez
Modified:
5 years, 9 months ago
CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-html_chromium.org, Rik, dglazkov+blink, dshwang, Justin Novosad
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Removed arbitrary 4096 size limit on WebGL canvas backbuffers (patchset #1 id:1 of https://codereview.chromium.org/1002523007/) Reason for revert: Suspected to break GPU bots, in the regression range of http://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA%29/builds/30393 which fails with WebglConformance.conformance_canvas_drawingbuffer_static_canvas_test. Another bot has the following error for that test so it could be related [1263:1287:0319/210147:INFO:CONSOLE(11)] "gl.drawingBufferWidth == 50 should be true. Was false.", source: (11) http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29/builds/9300/steps/webgl_conformance_tests/logs/WebglConformance.conformance_canvas_drawingbuffer_static_canvas_test Original issue's description: > Removed arbitrary 4096 size limit on WebGL canvas backbuffers > > BUG=445542 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192222 TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Corentin Wallez
Created Revert of Removed arbitrary 4096 size limit on WebGL canvas backbuffers
5 years, 9 months ago (2015-03-20 14:58:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022113002/1
5 years, 9 months ago (2015-03-20 14:58:40 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-20 14:58:43 UTC) #4
bajones
lgtm
5 years, 9 months ago (2015-03-20 15:48:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022113002/1
5 years, 9 months ago (2015-03-20 15:48:24 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 15:49:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192259

Powered by Google App Engine
This is Rietveld 408576698