Issue 1021723005: Load stocks data off the network

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1021723005: Load stocks data off the network (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw, ojan

CC:
rafaelw, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Load stocks data off the network Instead of hard-coding the stock data in the Dart file, this CL moves the data to a JSON file and loads that file over the network. This change improves load time for the Stocks app from 3 seconds to 2 seconds. Also, this CL removes shake-to-reload from the Stocks app because that also slows down load time (due to the two module systems fighting each other). R=rafaelw@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a8e9e800e4758aa605cbedd744c6b4589b4d8034

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3045 lines, -2975 lines)			Patch
M	sky/examples/stocks-fn/lib/stock_app.dart	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	sky/examples/stocks-fn/lib/stock_data.dart	View	2 chunks	+16 lines, -2967 lines	0 comments	Download
A	sky/examples/stocks-fn/lib/stock_data.json	View	1 chunk	+2965 lines, -0 lines	0 comments	Download
M	sky/examples/stocks-fn/main.sky	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/framework/components/fixed_height_scrollable.dart	View	3 chunks	+12 lines, -4 lines	0 comments	Download
A	sky/framework/net/fetch.dart	View	1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

5 years, 9 months ago (2015-03-23 16:59:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a8e9e800e4758aa605cbedd744c6b4589b4d8034 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages