Source/bindings/modules/v8/V8BindingForModules.h - Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/V8BindingForModules.h

Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed the compiler error behind ASSERT flag Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp ('k') | Source/bindings/modules/v8/V8BindingForModules.cpp » ('j') | Source/bindings/modules/v8/V8BindingForModulesTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/v8/V8BindingForModules.h

diff --git a/Source/bindings/modules/v8/V8BindingForModules.h b/Source/bindings/modules/v8/V8BindingForModules.h

index 5cfecbce82f6d58578e80ea2e0ba05ec97515cc6..0f71655f09458418db2e1f0864c3fc2eaa7289de 100644

--- a/Source/bindings/modules/v8/V8BindingForModules.h

+++ b/Source/bindings/modules/v8/V8BindingForModules.h

@@ -6,13 +6,13 @@

#define V8BindingForModules_h

#include "bindings/core/v8/V8Binding.h"

+#include "modules/indexeddb/IDBKeyPath.h"

#include "modules/webdatabase/sqlite/SQLValue.h"

namespace blink {

class IDBAny;

class IDBKey;

-class IDBKeyPath;

class IDBKeyRange;

class SerializedScriptValue;

class SharedBuffer;

@@ -22,7 +22,6 @@ class WebBlobInfo;

bool injectV8KeyIntoV8Value(v8::Isolate*, v8::Local<v8::Value> key, v8::Local<v8::Value>, const IDBKeyPath&);

// For use by Source/modules/indexeddb:

-IDBKey* createIDBKeyFromScriptValueAndKeyPath(v8::Isolate*, const ScriptValue&, const IDBKeyPath&);

bool canInjectIDBKeyIntoScriptValue(v8::Isolate*, const ScriptValue&, const IDBKeyPath&);

ScriptValue deserializeScriptValue(ScriptState*, SerializedScriptValue*, const Vector<blink::WebBlobInfo>*);

@@ -37,7 +36,7 @@ struct NativeValueTraits<SQLValue> {

template <>

struct NativeValueTraits<IDBKey*> {

- static IDBKey* nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);

+ static IDBKey* nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&, const IDBKeyPath& = IDBKeyPath());

jsbell 2015/03/19 16:46:57 It's possible that creating a temporary IDBKeyPath

vivekg 2015/03/19 17:46:52 Sure, we can have the overloaded method for non ID

};

template <>