[bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers…

Source/bindings/modules/v8/V8BindingForModules.h

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8BindingForModules_h
 #define V8BindingForModules_h
 
 #include "bindings/core/v8/V8Binding.h"
+#include "modules/indexeddb/IDBKeyPath.h"
 #include "modules/webdatabase/sqlite/SQLValue.h"
 
 namespace blink {
 
 class IDBAny;
 class IDBKey;
-class IDBKeyPath;
 class IDBKeyRange;
 class SerializedScriptValue;
 class SharedBuffer;
 class WebBlobInfo;
 
 // Exposed for unit testing:
 bool injectV8KeyIntoV8Value(v8::Isolate*, v8::Local<v8::Value> key, v8::Local<v8::Value>, const IDBKeyPath&);
 
 // For use by Source/modules/indexeddb:
-IDBKey* createIDBKeyFromScriptValueAndKeyPath(v8::Isolate*, const ScriptValue&, const IDBKeyPath&);
 bool canInjectIDBKeyIntoScriptValue(v8::Isolate*, const ScriptValue&, const IDBKeyPath&);
 ScriptValue deserializeScriptValue(ScriptState*, SerializedScriptValue*, const Vector<blink::WebBlobInfo>*);
 
 #if ENABLE(ASSERT)
 void assertPrimaryKeyValidOrInjectable(ScriptState*, PassRefPtr<SharedBuffer>, const Vector<blink::WebBlobInfo>*, IDBKey*, const IDBKeyPath&);
 #endif
 
 template <>
 struct NativeValueTraits<SQLValue> {
     static SQLValue nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
 };
 
 template <>
 struct NativeValueTraits<IDBKey*> {
-    static IDBKey* nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+    static IDBKey* nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&, const IDBKeyPath& = IDBKeyPath());

[jsbell, 2015/03/19 16:46:57]

It's possible that creating a temporary IDBKeyPath here in the non-keypath case
will show up as a performance regression. I'm fine with trying this as-is, but
if necessary will an overload work with the template function/traits approach?

[vivekg, 2015/03/19 17:46:52]

Sure, we can have the overloaded method for non IDBKeyPath case so as not to
affect the performance.

 };
 
 template <>
 struct NativeValueTraits<IDBKeyRange*> {
     static IDBKeyRange* nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
 };
 
 } // namespace blink
 
 #endif // V8BindingForModules_h