Source/bindings/core/v8/ScriptDebugServer.cpp - Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed the compiler error behind ASSERT flag Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/NativeValueTraits.h ('k') | Source/bindings/core/v8/ScriptValue.h » ('j') | Source/bindings/modules/v8/V8BindingForModules.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/ScriptDebugServer.cpp

diff --git a/Source/bindings/core/v8/ScriptDebugServer.cpp b/Source/bindings/core/v8/ScriptDebugServer.cpp

index b3216357a0b38304408919a6b39ce53a7967c4f8..bf4d8733035e5f80074c69877dd950f6265ef885 100644

--- a/Source/bindings/core/v8/ScriptDebugServer.cpp

+++ b/Source/bindings/core/v8/ScriptDebugServer.cpp

@@ -304,7 +304,8 @@ bool ScriptDebugServer::setScriptSource(const String& sourceID, const String& ne

case 0:

{

v8::Local<v8::Value> normalResult = resultTuple->Get(1);

- RefPtr<JSONValue> jsonResult = v8ToJSONValue(m_isolate, normalResult, JSONValue::maxDepth);

+ NonThrowableExceptionState exceptionState;

+ RefPtr<JSONValue> jsonResult = ScriptValue::to<JSONValuePtr>(m_isolate, normalResult, exceptionState);

if (jsonResult)

*result = jsonResult->asObject();

// Call stack may have changed after if the edited function was on the stack.

« no previous file with comments | « Source/bindings/core/v8/NativeValueTraits.h ('k') | Source/bindings/core/v8/ScriptValue.h » ('j') | Source/bindings/modules/v8/V8BindingForModules.h » ('J')