Source/bindings/core/v8/NativeValueTraits.h - Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/NativeValueTraits.h

Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed the compiler error behind ASSERT flag Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/NativeValueTraits.h

diff --git a/Source/bindings/core/v8/NativeValueTraits.h b/Source/bindings/core/v8/NativeValueTraits.h

index 6d553d0aacf0981866255c8f752dd8e0ace40057..29ef64422d4093d2a16d04c3a7f53f5f9888d657 100644

--- a/Source/bindings/core/v8/NativeValueTraits.h

+++ b/Source/bindings/core/v8/NativeValueTraits.h

@@ -11,9 +11,9 @@ namespace blink {

class ExceptionState;

-template <typename T>

+template <typename T, typename... Arguments>

struct NativeValueTraits {

- static T nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);

+ static T nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&, Arguments... args);

};

} // namespace blink

« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptDebugServer.cpp » ('j') | Source/bindings/modules/v8/V8BindingForModules.h » ('J')