Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1021483004: Revert of Remove Mac native font type members from FontPlatformData (Closed)

Created:
5 years, 9 months ago by Julien - ping for review
Modified:
5 years, 9 months ago
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove Mac native font type members from FontPlatformData (patchset #11 id:200001 of https://codereview.chromium.org/879533003/) Reason for revert: The patch broke the Mac GN builder, preventing the roll: ERROR at //third_party/WebKit/Source/platform/BUILD.gn:221:7: Item not found "fonts/skia/FontCustomPlatformDataSkia.cpp", It may have also caused some failures on Mac. Original issue's description: > Remove Mac native font type members from FontPlatformData > > FontPlatformData keeps several Mac specific font members > around, NSFont, ctFont, cgFont, while all other platforms > rely on just using an SkTypeface. This leads to a lot of > ifdefs in the code, confusion about which member is currently > instantiated and a history of null-dereference crashes on Mac > due to hard to track failures of font instantiation. > > After we got access to a CTFont object from an > SkTypeface for compatibility with HarfBuzz AAT shaping and > clipboard text export [1], I suggest to remove the native > handles and focus on using SkTypefaces. This allows us as > well to remove a lot of mostly redundant platform-specific > code on Mac. > > [1] https://codereview.chromium.org/872963003/ > > BUG=414234 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192506 TBR=eae@chromium.org,rsesek@chromium.org,kbr@chromium.org,japhet@chromium.org,pfeldman@chromium.org,tkent@chromium.org,alph@chromium.org,dominik.rottsches@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=414234 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+836 lines, -263 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/platform/blink_platform.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 3 chunks +4 lines, -1 line 0 comments Download
M Source/platform/fonts/FontCustomPlatformData.h View 2 chunks +11 lines, -0 lines 0 comments Download
D Source/platform/fonts/FontCustomPlatformData.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.h View 4 chunks +37 lines, -5 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.cpp View 12 chunks +76 lines, -24 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/fonts/mac/FontCacheMac.mm View 3 chunks +17 lines, -20 lines 0 comments Download
A Source/platform/fonts/mac/FontCustomPlatformDataMac.cpp View 1 chunk +78 lines, -0 lines 0 comments Download
M Source/platform/fonts/mac/FontPlatformDataMac.mm View 2 chunks +183 lines, -85 lines 0 comments Download
A Source/platform/fonts/mac/MemoryActivatedFont.h View 1 chunk +95 lines, -0 lines 0 comments Download
A Source/platform/fonts/mac/MemoryActivatedFont.mm View 1 chunk +207 lines, -0 lines 0 comments Download
A Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +117 lines, -0 lines 0 comments Download
M Source/web/mac/WebSubstringUtil.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Julien - ping for review
Created Revert of Remove Mac native font type members from FontPlatformData
5 years, 9 months ago (2015-03-25 15:33:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021483004/1
5 years, 9 months ago (2015-03-25 15:34:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192544
5 years, 9 months ago (2015-03-25 15:34:43 UTC) #5
Julien - ping for review
5 years, 9 months ago (2015-03-25 15:51:01 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1022663004/ by jchaffraix@chromium.org.

The reason for reverting is: Loislo and Dominik handled this in a better way.
For some reason, the "cancel commit" didn't work (or /me didn't)..

Powered by Google App Engine
This is Rietveld 408576698